Add AppArmor quick-fix warning and revert guidance in images README#244
Closed
Copilot wants to merge 2 commits into
Closed
Add AppArmor quick-fix warning and revert guidance in images README#244Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Agent-Logs-Url: https://github.com/AMDEPYC/sev-certify/sessions/51ca8234-e7b3-464c-9222-5461d508d186 Co-authored-by: amd-aliem <232466734+amd-aliem@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix code based on review comment
Add AppArmor quick-fix warning and revert guidance in images README
May 20, 2026
Contributor
|
i pressed the button expecting it to add it to my PR, but it opened this one against main for some reason. 👎 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The review flagged that the Ubuntu “Quick fix” AppArmor sysctl instructions lacked risk context and rollback guidance. This updates that section to clearly communicate system-wide impact, temporary persistence behavior, and how to revert.
Scope
images/README.mdin the Ubuntu AppArmor + mkosi section tied to the review comment.Documentation changes
sysctl -wquick fix.sysctl -wchanges are temporary unless persisted via/etc/sysctl.d.Example (added)