Enable batch_size>1 native decode (incl. true sub-64); bump compiler + tools#79
Merged
Conversation
b7403a8 to
56ed1e7
Compare
56ed1e7 to
230042a
Compare
Forward rows_per_batch/active_seq_per_batch from comparison_params to compare_vram_with_golden so a batch>1 decoder output compares only the active (rpb-strided) rows. Bump PLENA_Compiler and PLENA_Tools to their merged main commits: the batch>1 MHA decoder + head_dim>mlen kernel, and the rpb-strided comparison reader.
230042a to
86e7a3e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enables
batch_size>1native decode end-to-end, including true sub-64(mlen 16/32 < head_dim 64). Pairs the PLENA_Compiler decoder/kernel fix with the
PLENA_Tools comparison reader.
emulator_runner.py: forwardrows_per_batch/active_seq_per_batchfromcomparison_paramstocompare_vram_with_golden, so a batch>1 output comparesonly the active (rpb-strided) rows rather than all physical rows (which include
tile-align padding and false-negatived the match rate, e.g. 29% on a ~99%-correct run).
feat/multibatch-decoder(batch>1 MHA decoder + head_dim>mlen kernel).feat/multibatch-comparison(rpb-strided active-row reader).Companion PRs
Submodule pointers reference those PR branches; they'll be re-bumped to the merged
maincommits once the companions land.Test plan (numerical, allclose PASS)