Skip to content

refactor(agglayer): promote GER_KNOWN_FLAG to a const word #2970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PhilippGackstatter merged 2 commits into from
May 22, 2026
+8 −8
Merged

refactor(agglayer): promote GER_KNOWN_FLAG to a const word #2970

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c3e899
refactor(agglayer): promote GER_KNOWN_FLAG to a const word
claude May 22, 2026
dbb1f57
Merge branch 'next' into mmagician-claude/ger-known-const-word
mmagician May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions crates/miden-agglayer/asm/agglayer/bridge/bridge_config.masm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const TOKEN_REGISTRY_MAP_SLOT = word("agglayer::bridge::token_registry_map")
const FAUCET_METADATA_MAP_SLOT = word("agglayer::bridge::faucet_metadata_map")

# Flags
const GER_KNOWN_FLAG = 1
const GER_KNOWN_FLAG = [1, 0, 0, 0]
const FAUCET_REGISTERED_FLAG = 1

# Offset in the local memory of the `hash_token_address` procedure
Expand All @@ -53,7 +53,7 @@ const FAUCET_METADATA_SUBKEY_HASH_HI = 3 # METADATA_HASH_HI[4]
#! Updates the Global Exit Root (GER) in the bridge account storage.
#!
#! Computes hash(GER) = poseidon2::merge(GER_LOWER, GER_UPPER) and stores it in a map with value
#! [GER_KNOWN_FLAG, 0, 0, 0] to indicate the GER is known.
#! GER_KNOWN_FLAG to indicate the GER is known.
#!
#! Inputs: [GER_LOWER[4], GER_UPPER[4], pad(8)]
#! Outputs: [pad(16)]
Expand All @@ -71,9 +71,9 @@ pub proc update_ger
exec.poseidon2::merge
# => [GER_HASH, pad(12)]

# prepare VALUE = [GER_KNOWN_FLAG, 0, 0, 0]
push.0.0.0.GER_KNOWN_FLAG
# => [GER_KNOWN_FLAG, 0, 0, 0, GER_HASH, pad(12)]
# prepare VALUE = GER_KNOWN_FLAG
push.GER_KNOWN_FLAG
# => [GER_KNOWN_FLAG, GER_HASH, pad(12)]

swapw
# => [GER_HASH, VALUE, pad(12)]
Expand Down Expand Up @@ -111,9 +111,9 @@ pub proc assert_valid_ger
exec.active_account::get_map_item
# => [VALUE]

# assert the GER is known in storage (VALUE = [GER_KNOWN_FLAG, 0, 0, 0])
push.0.0.0.GER_KNOWN_FLAG
# => [GER_KNOWN_FLAG, 0, 0, 0, VALUE]
# assert the GER is known in storage (VALUE = GER_KNOWN_FLAG)
push.GER_KNOWN_FLAG
# => [GER_KNOWN_FLAG, VALUE]

assert_eqw.err=ERR_GER_NOT_FOUND
# => []
Expand Down
Loading