Skip to content

refactor(agglayer): promote GER_KNOWN_FLAG to a const word#2970

Merged
PhilippGackstatter merged 2 commits into
nextfrom
mmagician-claude/ger-known-const-word
May 22, 2026
Merged

refactor(agglayer): promote GER_KNOWN_FLAG to a const word#2970
PhilippGackstatter merged 2 commits into
nextfrom
mmagician-claude/ger-known-const-word

Conversation

@mmagician
Copy link
Copy Markdown
Collaborator

@mmagician mmagician commented May 22, 2026

Promote GER_KNOWN_FLAG from a single-felt constant (= 1) to a full Word constant (= [1, 0, 0, 0])

Declare GER_KNOWN_FLAG as a 4-felt word ([1, 0, 0, 0]) and replace the
two `push.0.0.0.GER_KNOWN_FLAG` call sites with `push.GER_KNOWN_FLAG`.
This mirrors the existing const-word pattern already used elsewhere in
the repo (e.g. IS_CLAIMED_FLAG in bridge_in.masm, IS_EXECUTED_FLAG in
multisig.masm, ALLOWED_WORD/BLOCKED_WORD in the standards crate).

These were the only two manual word constructions of this shape left in
the codebase. FAUCET_REGISTERED_FLAG stays a single felt because it is
combined with a runtime `is_native` value, so it cannot be promoted to a
standalone const word.
@mmagician mmagician added the no changelog This PR does not require an entry in the `CHANGELOG.md` file label May 22, 2026
@mmagician mmagician marked this pull request as ready for review May 22, 2026 08:54
@mmagician mmagician added the pr-from-maintainers PRs that come from internal contributors or integration partners. They should be given priority label May 22, 2026
@mmagician mmagician added the agglayer PRs or issues related to AggLayer bridging integration label May 22, 2026
@PhilippGackstatter PhilippGackstatter added this pull request to the merge queue May 22, 2026
Merged via the queue into next with commit df5d27e May 22, 2026
22 checks passed
@PhilippGackstatter PhilippGackstatter deleted the mmagician-claude/ger-known-const-word branch May 22, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agglayer PRs or issues related to AggLayer bridging integration no changelog This PR does not require an entry in the `CHANGELOG.md` file pr-from-maintainers PRs that come from internal contributors or integration partners. They should be given priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants