Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 1 addition & 15 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,18 +18,4 @@ Special Thanks to : Pir
- 구매 또는 판매한 상품 조회
- 전체 판매되고있는 상품 조회
- 상품 구매 - 이미 동일한 거래 시간에 상품 구매 예정이 되어있다면 다른 상품은 구매가 불가
- 상품 판매 - 상품을 등록, 수정, 삭제 할 수 있음


# 2주차
---

## 단독) 한국에 드디어 상륙한 캣츠! 티켓 1000장을 잡아라! ( 3.10 ~ 3.22 ) [ Feat. 김의빈 ]

### 요구사항
- 하나의 예매 서비스에 다량의 유저들이 접속한다는걸 가정합니다.
- 유저들은 접속하는 환경이 다를겁니다 ( ex. 모바일 , 컴퓨터 ) 하나의 서버가 아닌 여러 서버를 가정합니다.
- 뮤지컬의 경우 (날짜는 무관) 3일동안 1000장의 티켓이 발행됩니다.
- 1000장의 수량이 떨어질 경우 1001번째 사람은 티켓을 구매할 수 없습니다.
- 티켓을 이미 구매한 사람은 사제기의 요소를 방지하기 위해 더이상의 티켓을 구매할 순 없습니다.
- 티켓을 구매했을 경우 당일 뿐만이 아닌 다른날도 구매가 불가합니다.
- 상품 판매 - 상품을 등록, 수정, 삭제 할 수 있음
7 changes: 7 additions & 0 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,18 @@ dependencies {
// 쿼리 파라미터 로그
implementation 'com.github.gavlyukovskiy:p6spy-spring-boot-starter:1.5.8'

//Redisson
implementation 'org.redisson:redisson-spring-boot-starter:3.17.4'

compileOnly 'org.projectlombok:lombok'
runtimeOnly 'com.h2database:h2'
runtimeOnly 'com.mysql:mysql-connector-j'
annotationProcessor 'org.projectlombok:lombok'

//test
testImplementation 'org.springframework.boot:spring-boot-starter-test'
testCompileOnly 'org.projectlombok:lombok'
testAnnotationProcessor 'org.projectlombok:lombok'
}

tasks.named('test') {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@
import org.springframework.boot.autoconfigure.SpringBootApplication;

@SpringBootApplication
public class ZumgnmarketApplication {
public class WeeklyStudyProject {

public static void main(String[] args) {
SpringApplication.run(ZumgnmarketApplication.class, args);
SpringApplication.run(WeeklyStudyProject.class, args);
}

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
package com.week.zumgnmarket.common.config;

import org.springframework.context.annotation.Configuration;
import org.springframework.data.jpa.repository.config.EnableJpaAuditing;

@EnableJpaAuditing
@Configuration
public class JpaConfig {
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
package com.week.zumgnmarket.common.config;

import javax.persistence.EntityManager;
import javax.persistence.PersistenceContext;

import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;

import com.querydsl.jpa.impl.JPAQueryFactory;

@Configuration
public class QuerydslConfig {
@PersistenceContext
private EntityManager entityManager;

@Bean
public JPAQueryFactory jpaQueryFactory() {
return new JPAQueryFactory(entityManager);
}
}
23 changes: 23 additions & 0 deletions src/main/java/com/week/zumgnmarket/common/domain/BaseEntity.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
package com.week.zumgnmarket.common.domain;
import java.time.LocalDateTime;

import javax.persistence.EntityListeners;
import javax.persistence.MappedSuperclass;

import org.springframework.data.annotation.CreatedDate;
import org.springframework.data.annotation.LastModifiedDate;
import org.springframework.data.jpa.domain.support.AuditingEntityListener;

import lombok.Getter;

@Getter
@MappedSuperclass
@EntityListeners(AuditingEntityListener.class)
public class BaseEntity {
@CreatedDate
private LocalDateTime createdDate;

@LastModifiedDate
private LocalDateTime updatedDate;

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
package com.week.zumgnmarket.order.controller;

import org.springframework.http.ResponseEntity;
import org.springframework.web.bind.annotation.PostMapping;
import org.springframework.web.bind.annotation.RequestBody;
import org.springframework.web.bind.annotation.RequestMapping;
import org.springframework.web.bind.annotation.RestController;

import com.week.zumgnmarket.order.dto.OrderRequest;
import com.week.zumgnmarket.order.dto.OrderResponse;

import lombok.RequiredArgsConstructor;

@RestController
@RequiredArgsConstructor
@RequestMapping("/orders")
public class OrderController {

private final OrderFacade orderFacade;

@PostMapping("/tickets")
public ResponseEntity<OrderResponse> orderTickets(@RequestBody OrderRequest request) {
return ResponseEntity.ok(orderFacade.order(request));
}

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,79 @@
package com.week.zumgnmarket.order.controller;

import java.util.concurrent.TimeUnit;

import org.redisson.api.RLock;
import org.redisson.api.RedissonClient;
import org.springframework.stereotype.Component;
import org.springframework.transaction.annotation.Transactional;

import com.week.zumgnmarket.order.dto.OrderRequest;
import com.week.zumgnmarket.order.dto.OrderResponse;
import com.week.zumgnmarket.order.entity.Order;
import com.week.zumgnmarket.order.service.OrderService;
import com.week.zumgnmarket.ticket.entity.Ticket;
import com.week.zumgnmarket.ticket.service.TicketService;
import com.week.zumgnmarket.user.entity.User;
import com.week.zumgnmarket.user.service.UserService;

import lombok.RequiredArgsConstructor;

@Component
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Component@Service 어노테이션의 차이를 나누는 기준이 어떻게 되는지 궁굼합니다~

Copy link
Author

@yyy96 yyy96 Mar 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Facade 를 입사 후 처음 접하며 해당 부분에 대해서 @Component@Service 중 어느 것이 적합한지에 대해 좀 더 고민해보지 못했었던 것 같습니다..!

@Component@Service 둘 다 클래스를 컴포넌트로 등록하고 스프링 컨테이너에서 관리할 수 있도록 해주지만,
이때 @Service의 경우 좀더 세부적인 유스케이스 들을 위하여 @Component 의 구체화된 형태로서, 해당 클래스가 비즈니스 로직을 처리하는 서비스 역할을 한다는 것을 나타내주며 AOP에서 특정 작업을 수행하기 위해 다른 어노테이션과 결합하여 사용될 수도 있다는 것을 다시 한번 상기하였습니다.

처음 Facade 에 어노테이션을 붙일 때 메인 Service가 아니니 명시적인 의미로도 @Service 보단 @Component 가 적합하지 않을까? 하고 고민하였었는데요, 제 로직을 다시 보니 비즈니스?적인 로직들이 들어가있고, 해당 부분을 바탕으로 테스트를 진행한다는 점을 보면 @Service가 더 적합하려나..? 하는 생각이 드는 것도 같습니다..!

혹시 다른 좋은 기술적 의견이나 생각이 있으시다면 알려주시면 감사하겠습니다..!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Service 도 결국 @Component 를 상속받고 있어서 기술적인 차이는 없다고 생각해요.
단지 비즈니스 로직에 대한 구분 역할을 해준다고 생각합니다.

코드에 고민을 많이 하신 흔적이 보여서 연재님은 어떻게 생각하시는지 의견을 여쭈고자 질문드렸습니다!
지금 생각해보면 Facade 계층이라는 것을 직관적으로 알 수 있는 @FacadeService 같은 커스텀 어노테이션을 사용해서 직관적으로 개선 할 수도 있을 것 같아요 👍

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋은 말씀과 의견 감사합니다! 추후 리팩토링에 반영하도록 하겠습니다!!😊

@Transactional
@RequiredArgsConstructor
public class OrderFacade {

private final UserService userService;
private final TicketService ticketService;
private final OrderService orderService;
private final RedissonClient redissonClient;

public OrderResponse order(OrderRequest request) {
User user = userService.getUser(request.getUserId());
Ticket ticket = ticketService.getTicket(request.getTicketId());
Order order = orderService.orderTicket(user, ticket, request.getQuantity());

return OrderResponse.of(order, user, ticket);
}

public OrderResponse orderWithPessimisticLock(OrderRequest request) {
User user = userService.getUser(request.getUserId());
Ticket ticket = ticketService.getTicketWithPessimisticLock(request.getTicketId());
Order order = orderService.orderTicket(user, ticket, request.getQuantity());

return OrderResponse.of(order, user, ticket);
}

public OrderResponse orderWithOptimisticLock(OrderRequest request) throws InterruptedException {
User user = userService.getUser(request.getUserId());

//OptimisticLock 같은 경우 실패했을 때 재시도를 위해 while 을 사용하였습니다.
while (true) {
try {
Ticket ticket = ticketService.getTicketWithOptimisticLock(request.getTicketId());
Order order = orderService.orderTicket(user, ticket, request.getQuantity());
return OrderResponse.of(order, user, ticket);
} catch (Exception e) {
Thread.sleep(10);
}
}
}

public OrderResponse orderWithRedisson(OrderRequest request) {
User user = userService.getUser(request.getUserId());
RLock lock = redissonClient.getLock(request.getTicketId().toString());

try {
if (!lock.tryLock(2, 1, TimeUnit.SECONDS)) {
return new OrderResponse();
}
Ticket ticket = ticketService.getTicket(request.getTicketId());
Order order = orderService.orderTicket(user, ticket, request.getQuantity());
return OrderResponse.of(order, user, ticket);
} catch (InterruptedException e) {
throw new RuntimeException(e);
} finally {
lock.unlock();
}
}
}
16 changes: 16 additions & 0 deletions src/main/java/com/week/zumgnmarket/order/dto/OrderRequest.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
package com.week.zumgnmarket.order.dto;

import lombok.Getter;

@Getter
public class OrderRequest {
public Long userId;
public Long ticketId;
public int quantity;

public OrderRequest(Long userId, Long ticketId, int quantity) {
this.userId = userId;
this.ticketId = ticketId;
this.quantity = quantity;
}
}
35 changes: 35 additions & 0 deletions src/main/java/com/week/zumgnmarket/order/dto/OrderResponse.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
package com.week.zumgnmarket.order.dto;

import com.week.zumgnmarket.order.entity.Order;
import com.week.zumgnmarket.ticket.entity.Ticket;
import com.week.zumgnmarket.user.entity.User;

import lombok.Builder;
import lombok.Getter;
import lombok.NoArgsConstructor;

@Getter
@NoArgsConstructor
public class OrderResponse {
public Long orderId;
public Long userId;
public Long ticketId;
public int quantity;

@Builder
public OrderResponse(Long orderId, Long userId, Long ticketId, int quantity) {
this.orderId = orderId;
this.userId = userId;
this.ticketId = ticketId;
this.quantity = quantity;
}

public static OrderResponse of(Order order, User user, Ticket ticket) {
return OrderResponse.builder()
.orderId(order.getId())
.userId(user.getId())
.ticketId(ticket.getId())
.quantity(order.getTicketCount())
.build();
}
}
58 changes: 58 additions & 0 deletions src/main/java/com/week/zumgnmarket/order/entity/Order.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
package com.week.zumgnmarket.order.entity;

import static javax.persistence.FetchType.*;

import javax.persistence.Embedded;
import javax.persistence.Entity;
import javax.persistence.GeneratedValue;
import javax.persistence.GenerationType;
import javax.persistence.Id;
import javax.persistence.JoinColumn;
import javax.persistence.ManyToOne;
import javax.persistence.Table;

import com.week.zumgnmarket.common.domain.BaseEntity;
import com.week.zumgnmarket.ticket.entity.Ticket;
import com.week.zumgnmarket.user.entity.User;

import lombok.AccessLevel;
import lombok.Builder;
import lombok.Getter;
import lombok.NoArgsConstructor;
import lombok.ToString;

@Entity
@Getter
@ToString
@NoArgsConstructor(access = AccessLevel.PROTECTED)
@Table(name = "orders")
public class Order extends BaseEntity {
@Id
@GeneratedValue(strategy = GenerationType.IDENTITY)
private Long id;

@ManyToOne(fetch = LAZY)
@JoinColumn(name = "user_id")
private User user;

@ManyToOne(fetch = LAZY)
@JoinColumn(name = "ticket_id")
private Ticket ticket;

private int ticketCount;

@Builder
private Order(User user, Ticket ticket, int ticketCount) {
this.user = user;
this.ticket = ticket;
this.ticketCount = ticketCount;
}

public static Order of(User user, Ticket ticket, int ticketCount) {
return Order.builder()
.user(user)
.ticket(ticket)
.ticketCount(ticketCount)
.build();
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
package com.week.zumgnmarket.order.entity;

import org.springframework.data.jpa.repository.JpaRepository;

public interface OrderRepository extends JpaRepository<Order, Long> {
}
18 changes: 18 additions & 0 deletions src/main/java/com/week/zumgnmarket/order/entity/Orders.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
package com.week.zumgnmarket.order.entity;

import java.util.ArrayList;
import java.util.List;

import javax.persistence.CascadeType;
import javax.persistence.Embeddable;
import javax.persistence.OneToMany;

import lombok.Getter;

@Getter
@Embeddable
public class Orders {
@OneToMany(mappedBy = "user", cascade = CascadeType.ALL, orphanRemoval = true)
List<Order> orders = new ArrayList<>();

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
package com.week.zumgnmarket.order.service;

import org.springframework.stereotype.Service;

import com.week.zumgnmarket.order.entity.Order;
import com.week.zumgnmarket.ticket.entity.Ticket;
import com.week.zumgnmarket.user.entity.User;

import lombok.RequiredArgsConstructor;

/**
* Optimistic Lock
* Lock 이 아니라 Version 을 통해 정합성을 맞추는 방법.
* 처음에 현재 데이터의 version 을 읽고,
* 이후 update 하는 시점에서 처음 읽은 버전과 동일한지 확인 후 update 수행.
* */

@Service
@RequiredArgsConstructor
public class OptimisticLockOrderService implements OrderService{

@Override
public Order orderTicket(User user, Ticket ticket, int quantity) {
ticket.decreaseQuantity(quantity);
return Order.of(user, ticket, quantity);
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
package com.week.zumgnmarket.order.service;

import com.week.zumgnmarket.order.entity.Order;
import com.week.zumgnmarket.ticket.entity.Ticket;
import com.week.zumgnmarket.user.entity.User;

public interface OrderService {
Order orderTicket(User user, Ticket ticket, int quantity);
}
Loading