-
Notifications
You must be signed in to change notification settings - Fork 5
2주차 : 줌터파크 과제 제출합니다. #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
yyy96
wants to merge
13
commits into
zum-spring-study:main
Choose a base branch
from
yyy96:concurrency
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
2de8306
Update README.md
yyy96 3302658
setting: update setting
yyy96 792215b
setting: update setting
yyy96 010ae3b
feat: 엔티티 연관관계 매핑
yyy96 428f6a4
feat: 티켓 주문 기본 API 구현
yyy96 f7b264a
feat: 티켓 주문 서비스 synchronized 적용
yyy96 29ff99d
refactor: 주석,exception 등 기타 리팩터링
yyy96 e94afc9
feat: 티켓 주문 서비스 PessimisticLock 적용 (error)
yyy96 4e70400
feat: 티켓 주문 서비스 OptimisticLock 적용 (error)
yyy96 2b88904
feat: 티켓 주문 서비스 RedissonLock 적용 (error)
yyy96 703a852
refactor: 중복 error message 분리
yyy96 04d06ea
Merge branch 'main' into concurrency
yyy96 ab5189d
fix: 엔티티 변경감지 이슈 해결 (데드락 미해결)
yyy96 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 9 additions & 0 deletions
9
src/main/java/com/week/zumgnmarket/common/config/JpaConfig.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| package com.week.zumgnmarket.common.config; | ||
|
|
||
| import org.springframework.context.annotation.Configuration; | ||
| import org.springframework.data.jpa.repository.config.EnableJpaAuditing; | ||
|
|
||
| @EnableJpaAuditing | ||
| @Configuration | ||
| public class JpaConfig { | ||
| } |
20 changes: 20 additions & 0 deletions
20
src/main/java/com/week/zumgnmarket/common/config/QuerydslConfig.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| package com.week.zumgnmarket.common.config; | ||
|
|
||
| import javax.persistence.EntityManager; | ||
| import javax.persistence.PersistenceContext; | ||
|
|
||
| import org.springframework.context.annotation.Bean; | ||
| import org.springframework.context.annotation.Configuration; | ||
|
|
||
| import com.querydsl.jpa.impl.JPAQueryFactory; | ||
|
|
||
| @Configuration | ||
| public class QuerydslConfig { | ||
| @PersistenceContext | ||
| private EntityManager entityManager; | ||
|
|
||
| @Bean | ||
| public JPAQueryFactory jpaQueryFactory() { | ||
| return new JPAQueryFactory(entityManager); | ||
| } | ||
| } |
23 changes: 23 additions & 0 deletions
23
src/main/java/com/week/zumgnmarket/common/domain/BaseEntity.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| package com.week.zumgnmarket.common.domain; | ||
| import java.time.LocalDateTime; | ||
|
|
||
| import javax.persistence.EntityListeners; | ||
| import javax.persistence.MappedSuperclass; | ||
|
|
||
| import org.springframework.data.annotation.CreatedDate; | ||
| import org.springframework.data.annotation.LastModifiedDate; | ||
| import org.springframework.data.jpa.domain.support.AuditingEntityListener; | ||
|
|
||
| import lombok.Getter; | ||
|
|
||
| @Getter | ||
| @MappedSuperclass | ||
| @EntityListeners(AuditingEntityListener.class) | ||
| public class BaseEntity { | ||
| @CreatedDate | ||
| private LocalDateTime createdDate; | ||
|
|
||
| @LastModifiedDate | ||
| private LocalDateTime updatedDate; | ||
|
|
||
| } |
26 changes: 26 additions & 0 deletions
26
src/main/java/com/week/zumgnmarket/order/controller/OrderController.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| package com.week.zumgnmarket.order.controller; | ||
|
|
||
| import org.springframework.http.ResponseEntity; | ||
| import org.springframework.web.bind.annotation.PostMapping; | ||
| import org.springframework.web.bind.annotation.RequestBody; | ||
| import org.springframework.web.bind.annotation.RequestMapping; | ||
| import org.springframework.web.bind.annotation.RestController; | ||
|
|
||
| import com.week.zumgnmarket.order.dto.OrderRequest; | ||
| import com.week.zumgnmarket.order.dto.OrderResponse; | ||
|
|
||
| import lombok.RequiredArgsConstructor; | ||
|
|
||
| @RestController | ||
| @RequiredArgsConstructor | ||
| @RequestMapping("/orders") | ||
| public class OrderController { | ||
|
|
||
| private final OrderFacade orderFacade; | ||
|
|
||
| @PostMapping("/tickets") | ||
| public ResponseEntity<OrderResponse> orderTickets(@RequestBody OrderRequest request) { | ||
| return ResponseEntity.ok(orderFacade.order(request)); | ||
| } | ||
|
|
||
| } |
79 changes: 79 additions & 0 deletions
79
src/main/java/com/week/zumgnmarket/order/controller/OrderFacade.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| package com.week.zumgnmarket.order.controller; | ||
|
|
||
| import java.util.concurrent.TimeUnit; | ||
|
|
||
| import org.redisson.api.RLock; | ||
| import org.redisson.api.RedissonClient; | ||
| import org.springframework.stereotype.Component; | ||
| import org.springframework.transaction.annotation.Transactional; | ||
|
|
||
| import com.week.zumgnmarket.order.dto.OrderRequest; | ||
| import com.week.zumgnmarket.order.dto.OrderResponse; | ||
| import com.week.zumgnmarket.order.entity.Order; | ||
| import com.week.zumgnmarket.order.service.OrderService; | ||
| import com.week.zumgnmarket.ticket.entity.Ticket; | ||
| import com.week.zumgnmarket.ticket.service.TicketService; | ||
| import com.week.zumgnmarket.user.entity.User; | ||
| import com.week.zumgnmarket.user.service.UserService; | ||
|
|
||
| import lombok.RequiredArgsConstructor; | ||
|
|
||
| @Component | ||
| @Transactional | ||
| @RequiredArgsConstructor | ||
| public class OrderFacade { | ||
|
|
||
| private final UserService userService; | ||
| private final TicketService ticketService; | ||
| private final OrderService orderService; | ||
| private final RedissonClient redissonClient; | ||
|
|
||
| public OrderResponse order(OrderRequest request) { | ||
| User user = userService.getUser(request.getUserId()); | ||
| Ticket ticket = ticketService.getTicket(request.getTicketId()); | ||
| Order order = orderService.orderTicket(user, ticket, request.getQuantity()); | ||
|
|
||
| return OrderResponse.of(order, user, ticket); | ||
| } | ||
|
|
||
| public OrderResponse orderWithPessimisticLock(OrderRequest request) { | ||
| User user = userService.getUser(request.getUserId()); | ||
| Ticket ticket = ticketService.getTicketWithPessimisticLock(request.getTicketId()); | ||
| Order order = orderService.orderTicket(user, ticket, request.getQuantity()); | ||
|
|
||
| return OrderResponse.of(order, user, ticket); | ||
| } | ||
|
|
||
| public OrderResponse orderWithOptimisticLock(OrderRequest request) throws InterruptedException { | ||
| User user = userService.getUser(request.getUserId()); | ||
|
|
||
| //OptimisticLock 같은 경우 실패했을 때 재시도를 위해 while 을 사용하였습니다. | ||
| while (true) { | ||
| try { | ||
| Ticket ticket = ticketService.getTicketWithOptimisticLock(request.getTicketId()); | ||
| Order order = orderService.orderTicket(user, ticket, request.getQuantity()); | ||
| return OrderResponse.of(order, user, ticket); | ||
| } catch (Exception e) { | ||
| Thread.sleep(10); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| public OrderResponse orderWithRedisson(OrderRequest request) { | ||
| User user = userService.getUser(request.getUserId()); | ||
| RLock lock = redissonClient.getLock(request.getTicketId().toString()); | ||
|
|
||
| try { | ||
| if (!lock.tryLock(2, 1, TimeUnit.SECONDS)) { | ||
| return new OrderResponse(); | ||
| } | ||
| Ticket ticket = ticketService.getTicket(request.getTicketId()); | ||
| Order order = orderService.orderTicket(user, ticket, request.getQuantity()); | ||
| return OrderResponse.of(order, user, ticket); | ||
| } catch (InterruptedException e) { | ||
| throw new RuntimeException(e); | ||
| } finally { | ||
| lock.unlock(); | ||
| } | ||
| } | ||
| } | ||
16 changes: 16 additions & 0 deletions
16
src/main/java/com/week/zumgnmarket/order/dto/OrderRequest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| package com.week.zumgnmarket.order.dto; | ||
|
|
||
| import lombok.Getter; | ||
|
|
||
| @Getter | ||
| public class OrderRequest { | ||
| public Long userId; | ||
| public Long ticketId; | ||
| public int quantity; | ||
|
|
||
| public OrderRequest(Long userId, Long ticketId, int quantity) { | ||
| this.userId = userId; | ||
| this.ticketId = ticketId; | ||
| this.quantity = quantity; | ||
| } | ||
| } |
35 changes: 35 additions & 0 deletions
35
src/main/java/com/week/zumgnmarket/order/dto/OrderResponse.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| package com.week.zumgnmarket.order.dto; | ||
|
|
||
| import com.week.zumgnmarket.order.entity.Order; | ||
| import com.week.zumgnmarket.ticket.entity.Ticket; | ||
| import com.week.zumgnmarket.user.entity.User; | ||
|
|
||
| import lombok.Builder; | ||
| import lombok.Getter; | ||
| import lombok.NoArgsConstructor; | ||
|
|
||
| @Getter | ||
| @NoArgsConstructor | ||
| public class OrderResponse { | ||
| public Long orderId; | ||
| public Long userId; | ||
| public Long ticketId; | ||
| public int quantity; | ||
|
|
||
| @Builder | ||
| public OrderResponse(Long orderId, Long userId, Long ticketId, int quantity) { | ||
| this.orderId = orderId; | ||
| this.userId = userId; | ||
| this.ticketId = ticketId; | ||
| this.quantity = quantity; | ||
| } | ||
|
|
||
| public static OrderResponse of(Order order, User user, Ticket ticket) { | ||
| return OrderResponse.builder() | ||
| .orderId(order.getId()) | ||
| .userId(user.getId()) | ||
| .ticketId(ticket.getId()) | ||
| .quantity(order.getTicketCount()) | ||
| .build(); | ||
| } | ||
| } |
58 changes: 58 additions & 0 deletions
58
src/main/java/com/week/zumgnmarket/order/entity/Order.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| package com.week.zumgnmarket.order.entity; | ||
|
|
||
| import static javax.persistence.FetchType.*; | ||
|
|
||
| import javax.persistence.Embedded; | ||
| import javax.persistence.Entity; | ||
| import javax.persistence.GeneratedValue; | ||
| import javax.persistence.GenerationType; | ||
| import javax.persistence.Id; | ||
| import javax.persistence.JoinColumn; | ||
| import javax.persistence.ManyToOne; | ||
| import javax.persistence.Table; | ||
|
|
||
| import com.week.zumgnmarket.common.domain.BaseEntity; | ||
| import com.week.zumgnmarket.ticket.entity.Ticket; | ||
| import com.week.zumgnmarket.user.entity.User; | ||
|
|
||
| import lombok.AccessLevel; | ||
| import lombok.Builder; | ||
| import lombok.Getter; | ||
| import lombok.NoArgsConstructor; | ||
| import lombok.ToString; | ||
|
|
||
| @Entity | ||
| @Getter | ||
| @ToString | ||
| @NoArgsConstructor(access = AccessLevel.PROTECTED) | ||
| @Table(name = "orders") | ||
| public class Order extends BaseEntity { | ||
| @Id | ||
| @GeneratedValue(strategy = GenerationType.IDENTITY) | ||
| private Long id; | ||
|
|
||
| @ManyToOne(fetch = LAZY) | ||
| @JoinColumn(name = "user_id") | ||
| private User user; | ||
|
|
||
| @ManyToOne(fetch = LAZY) | ||
| @JoinColumn(name = "ticket_id") | ||
| private Ticket ticket; | ||
|
|
||
| private int ticketCount; | ||
|
|
||
| @Builder | ||
| private Order(User user, Ticket ticket, int ticketCount) { | ||
| this.user = user; | ||
| this.ticket = ticket; | ||
| this.ticketCount = ticketCount; | ||
| } | ||
|
|
||
| public static Order of(User user, Ticket ticket, int ticketCount) { | ||
| return Order.builder() | ||
| .user(user) | ||
| .ticket(ticket) | ||
| .ticketCount(ticketCount) | ||
| .build(); | ||
| } | ||
| } |
6 changes: 6 additions & 0 deletions
6
src/main/java/com/week/zumgnmarket/order/entity/OrderRepository.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| package com.week.zumgnmarket.order.entity; | ||
|
|
||
| import org.springframework.data.jpa.repository.JpaRepository; | ||
|
|
||
| public interface OrderRepository extends JpaRepository<Order, Long> { | ||
| } |
18 changes: 18 additions & 0 deletions
18
src/main/java/com/week/zumgnmarket/order/entity/Orders.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| package com.week.zumgnmarket.order.entity; | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.List; | ||
|
|
||
| import javax.persistence.CascadeType; | ||
| import javax.persistence.Embeddable; | ||
| import javax.persistence.OneToMany; | ||
|
|
||
| import lombok.Getter; | ||
|
|
||
| @Getter | ||
| @Embeddable | ||
| public class Orders { | ||
| @OneToMany(mappedBy = "user", cascade = CascadeType.ALL, orphanRemoval = true) | ||
| List<Order> orders = new ArrayList<>(); | ||
|
|
||
| } |
27 changes: 27 additions & 0 deletions
27
src/main/java/com/week/zumgnmarket/order/service/OptimisticLockOrderService.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| package com.week.zumgnmarket.order.service; | ||
|
|
||
| import org.springframework.stereotype.Service; | ||
|
|
||
| import com.week.zumgnmarket.order.entity.Order; | ||
| import com.week.zumgnmarket.ticket.entity.Ticket; | ||
| import com.week.zumgnmarket.user.entity.User; | ||
|
|
||
| import lombok.RequiredArgsConstructor; | ||
|
|
||
| /** | ||
| * Optimistic Lock | ||
| * Lock 이 아니라 Version 을 통해 정합성을 맞추는 방법. | ||
| * 처음에 현재 데이터의 version 을 읽고, | ||
| * 이후 update 하는 시점에서 처음 읽은 버전과 동일한지 확인 후 update 수행. | ||
| * */ | ||
|
|
||
| @Service | ||
| @RequiredArgsConstructor | ||
| public class OptimisticLockOrderService implements OrderService{ | ||
|
|
||
| @Override | ||
| public Order orderTicket(User user, Ticket ticket, int quantity) { | ||
| ticket.decreaseQuantity(quantity); | ||
| return Order.of(user, ticket, quantity); | ||
| } | ||
| } |
9 changes: 9 additions & 0 deletions
9
src/main/java/com/week/zumgnmarket/order/service/OrderService.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| package com.week.zumgnmarket.order.service; | ||
|
|
||
| import com.week.zumgnmarket.order.entity.Order; | ||
| import com.week.zumgnmarket.ticket.entity.Ticket; | ||
| import com.week.zumgnmarket.user.entity.User; | ||
|
|
||
| public interface OrderService { | ||
| Order orderTicket(User user, Ticket ticket, int quantity); | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Component와@Service어노테이션의 차이를 나누는 기준이 어떻게 되는지 궁굼합니다~Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Facade 를 입사 후 처음 접하며 해당 부분에 대해서
@Component와@Service중 어느 것이 적합한지에 대해 좀 더 고민해보지 못했었던 것 같습니다..!@Component와@Service둘 다 클래스를 컴포넌트로 등록하고 스프링 컨테이너에서 관리할 수 있도록 해주지만,이때
@Service의 경우 좀더 세부적인 유스케이스 들을 위하여@Component의 구체화된 형태로서, 해당 클래스가 비즈니스 로직을 처리하는 서비스 역할을 한다는 것을 나타내주며 AOP에서 특정 작업을 수행하기 위해 다른 어노테이션과 결합하여 사용될 수도 있다는 것을 다시 한번 상기하였습니다.처음 Facade 에 어노테이션을 붙일 때 메인 Service가 아니니 명시적인 의미로도
@Service보단@Component가 적합하지 않을까? 하고 고민하였었는데요, 제 로직을 다시 보니 비즈니스?적인 로직들이 들어가있고, 해당 부분을 바탕으로 테스트를 진행한다는 점을 보면@Service가 더 적합하려나..? 하는 생각이 드는 것도 같습니다..!혹시 다른 좋은 기술적 의견이나 생각이 있으시다면 알려주시면 감사하겠습니다..!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Service도 결국@Component를 상속받고 있어서 기술적인 차이는 없다고 생각해요.단지 비즈니스 로직에 대한 구분 역할을 해준다고 생각합니다.
코드에 고민을 많이 하신 흔적이 보여서 연재님은 어떻게 생각하시는지 의견을 여쭈고자 질문드렸습니다!
지금 생각해보면 Facade 계층이라는 것을 직관적으로 알 수 있는
@FacadeService같은 커스텀 어노테이션을 사용해서 직관적으로 개선 할 수도 있을 것 같아요 👍There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
좋은 말씀과 의견 감사합니다! 추후 리팩토링에 반영하도록 하겠습니다!!😊