Open
Conversation
Owner
|
Hi LumenTeun, Thanks for your contribution. It seems that the code looks all good, but I haven't tested it yet. One way to make the change apply on the go is by adding this code in updateSettings() inside BatteryBarView.java updateSettings() is called when any setting is changed, so it should work, although again, I haven't tested this. I'll try to test it once I find some time :p Regards, |
Author
|
Okay, that makes it change as soon as the settings are changed. Thanks for the code snippet. :) |
Author
|
Was there any reason not to pull this? I've got the Xposed Repo version installed on my phone and since there's no settings export, going between apks signed with different keys are a hastle. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I loved the battery bar charging animation, but I got stressed out and distracted from how quickly it fired so I added the option to set an offset between animations.
You might need to restart the system UI to see the difference. (Slowly de- and reactivating the charge animation works as well. It just needs start() to run. I'll try to make it cleaner once I fully figure out your code.)