Skip to content

can exclude some args from defaultChromeArgs #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
unlimitun wants to merge 1 commit into
base: master
Choose a base branch
from
Open

can exclude some args from defaultChromeArgs #191

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions ui.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,12 @@ var defaultChromeArgs = []string{

// New returns a new HTML5 UI for the given URL, user profile directory, window
// size and other options passed to the browser engine. If URL is an empty
// excludeDefaultArgs, if you don not want to use some default Chrome args, you can add them by slice
// string - a blank page is displayed. If user profile directory is an empty
// string - a temporary directory is created and it will be removed on
// ui.Close(). You might want to use "--headless" custom CLI argument to test
// your UI code.
func New(url, dir string, width, height int, customArgs ...string) (UI, error) {
func New(url, dir string, width, height int, excludeDefaultArgs []string, customArgs ...string) (UI, error) {
if url == "" {
url = "data:text/html,<html></html>"
}
Expand All @@ -72,7 +73,8 @@ func New(url, dir string, width, height int, customArgs ...string) (UI, error) {
}
dir, tmpDir = name, name
}
args := append(defaultChromeArgs, fmt.Sprintf("--app=%s", url))
finallyChromeArgs := mergeArgs(defaultChromeArgs, excludeDefaultArgs)
args := append(finallyChromeArgs, fmt.Sprintf("--app=%s", url))
args = append(args, fmt.Sprintf("--user-data-dir=%s", dir))
args = append(args, fmt.Sprintf("--window-size=%d,%d", width, height))
args = append(args, customArgs...)
Expand Down Expand Up @@ -174,3 +176,22 @@ func (u *ui) SetBounds(b Bounds) error {
func (u *ui) Bounds() (Bounds, error) {
return u.chrome.bounds()
}

func mergeArgs(defaultArgs []string, excludeArgs []string) []string {
result := []string{}
for _, arg := range defaultArgs {
if !has(excludeArgs, arg) {
result = append(result, arg)
}
}
return result
}

func has(source []string, target string) bool {
for _, s := range source {
if s == target {
return true
}
}
return false
}