Merged
Conversation
added 4 commits
April 4, 2026 13:33
- Refactor method implementations to use block syntax for better clarity. - Update comments to maintain consistent formatting and improve documentation. - Adjust variable declarations for enhanced readability. - Organize namespaces and remove unnecessary using directives. - Ensure consistent use of access modifiers in interface methods.
- Refactor method implementations to use block syntax for clarity. - Update comments for consistent formatting and improved documentation. - Adjust variable declarations for enhanced readability. - Organize namespaces and remove unnecessary using directives. - Ensure consistent use of access modifiers in interface methods.
…ling - Add text column type for Parameters, ResultPayload, and ErrorMessage in JobExecutionConfiguration. - Change HtmlBody property to use text column type in FailedEmailConfiguration. - Introduce max length constraint for CategoryName in ProductCategoryStatsConfiguration.
…nToken in async method calls - Modify all async method calls in InMemoryIdempotencyStoreTests to accept a CancellationToken parameter. - Ensure consistent usage of CancellationToken across test cases for better control over task cancellation.
- Add PermissionAuthorizationHandler to manage role-based permissions. - Introduce PermissionPolicyProvider for dynamic authorization policies. - Create PermissionRequirement for defining permission requirements. - Implement caching options and services for efficient data retrieval. - Add middleware for CSRF protection and request context management. - Enhance OpenAPI documentation with error response handling and health check endpoints.
There was a problem hiding this comment.
Pull request overview
This PR is primarily a cleanup/refactor pass across multiple modules, focusing on formatting consistency, removing unused using directives, and making small structural adjustments (e.g., method bodies, type declarations, and configuration details).
Changes:
- Standardized formatting (XML docs wrapping, braces, block-bodied members, whitespace) across many files.
- Removed unused imports and simplified/qualified type references to reduce clutter.
- Made a few small functional/configuration tweaks (e.g., EF column types/lengths, minor middleware and stored-procedure formatting updates).
Reviewed changes
Copilot reviewed 258 out of 587 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Modules/ProductCatalog/Features/Product/GetProducts/ProductSpecification.cs | XML doc formatting cleanup. |
| src/Modules/ProductCatalog/Features/Product/GetProducts/ProductFilterValidator.cs | Removed unused using + doc formatting cleanup. |
| src/Modules/ProductCatalog/Features/Product/GetProducts/ProductFilterCriteria.cs | Added braces for readability; doc formatting cleanup. |
| src/Modules/ProductCatalog/Features/Product/GetProducts/ProductFilter.cs | Removed unused usings + doc formatting cleanup. |
| src/Modules/ProductCatalog/Features/Product/GetProductById/ProductsController.GetProductById.cs | Removed unused usings. |
| src/Modules/ProductCatalog/Features/Product/GetProductById/ProductByIdWithLinksSpecification.cs | XML doc formatting cleanup. |
| src/Modules/ProductCatalog/Features/Product/GetProductById/ProductByIdSpecification.cs | XML doc formatting cleanup. |
| src/Modules/ProductCatalog/Features/Product/DeleteProducts/ProductsController.DeleteProducts.cs | Removed unused usings. |
| src/Modules/ProductCatalog/Features/Product/DeleteProducts/DeleteProductsCommand.cs | Refactor: type aliasing/qualification + moved state record; doc formatting cleanup. |
| src/Modules/ProductCatalog/Features/Product/CreateProducts/ProductsController.CreateProducts.cs | Removed unused usings. |
| src/Modules/ProductCatalog/Features/Product/CreateProducts/CreateProductsCommand.cs | Removed unused usings + doc formatting cleanup. |
| src/Modules/ProductCatalog/Features/Product/CreateProducts/CreateProductRequestValidator.cs | XML doc formatting cleanup. |
| src/Modules/ProductCatalog/Features/Category/UpdateCategories/UpdateCategoryItemValidator.cs | Removed unused usings. |
| src/Modules/ProductCatalog/Features/Category/UpdateCategories/UpdateCategoriesRequest.cs | Removed unused using. |
| src/Modules/ProductCatalog/Features/Category/UpdateCategories/UpdateCategoriesCommand.cs | Refactor: stronger concrete types + moved state record; doc formatting cleanup. |
| src/Modules/ProductCatalog/Features/Category/UpdateCategories/CategoriesController.UpdateCategories.cs | Removed unused usings. |
| src/Modules/ProductCatalog/Features/Category/Shared/CategorySortFields.cs | Removed unused using. |
| src/Modules/ProductCatalog/Features/Category/Shared/CategoryMappings.cs | Converted expression-bodied member to block body. |
| src/Modules/ProductCatalog/Features/Category/GetCategoryStats/GetCategoryStatsQuery.cs | Removed unused using. |
| src/Modules/ProductCatalog/Features/Category/GetCategoryStats/CategoriesController.GetCategoryStats.cs | Removed unused usings. |
| src/Modules/ProductCatalog/Features/Category/GetCategoryById/GetCategoryByIdQuery.cs | Removed unused using. |
| src/Modules/ProductCatalog/Features/Category/GetCategoryById/CategoryByIdSpecification.cs | XML doc formatting cleanup. |
| src/Modules/ProductCatalog/Features/Category/GetCategoryById/CategoriesController.GetCategoryById.cs | Removed unused usings. |
| src/Modules/ProductCatalog/Features/Category/GetCategories/CategorySpecification.cs | XML doc formatting cleanup. |
| src/Modules/ProductCatalog/Features/Category/GetCategories/CategoryFilterValidator.cs | Removed unused using. |
| src/Modules/ProductCatalog/Features/Category/GetCategories/CategoryFilterCriteria.cs | Removed unused using + doc wrapping. |
| src/Modules/ProductCatalog/Features/Category/GetCategories/CategoryFilter.cs | Removed unused usings. |
| src/Modules/ProductCatalog/Features/Category/GetCategories/CategoriesController.GetCategories.cs | Removed unused usings. |
| src/Modules/ProductCatalog/Features/Category/DeleteCategories/DeleteCategoriesCommand.cs | Refactor: concrete types + formatting cleanup. |
| src/Modules/ProductCatalog/Features/Category/DeleteCategories/CategoriesController.DeleteCategories.cs | Removed unused usings. |
| src/Modules/ProductCatalog/Features/Category/CreateCategories/CreateCategoryRequestValidator.cs | Removed unused usings. |
| src/Modules/ProductCatalog/Features/Category/CreateCategories/CreateCategoryRequest.cs | Removed unused using. |
| src/Modules/ProductCatalog/Features/Category/CreateCategories/CreateCategoriesCommand.cs | Removed unused usings. |
| src/Modules/ProductCatalog/Features/Category/CreateCategories/CategoriesController.CreateCategories.cs | Removed unused usings. |
| src/Modules/ProductCatalog/Features/Category/CategoriesController.cs | Removed unused usings. |
| src/Modules/ProductCatalog/Entities/ProductDataLink.cs | Refactor: moved navigation property; block-bodied factory method; whitespace cleanup. |
| src/Modules/ProductCatalog/Entities/ProductData/VideoProductData.cs | Whitespace/doc formatting cleanup. |
| src/Modules/ProductCatalog/Entities/ProductData/ProductData.cs | Reordered Id property; doc formatting cleanup. |
| src/Modules/ProductCatalog/Entities/ProductData/ImageProductData.cs | Whitespace/doc formatting cleanup. |
| src/Modules/ProductCatalog/Entities/ProductCategoryStats.cs | Trailing whitespace cleanup. |
| src/Modules/ProductCatalog/Entities/Product.cs | Moved Id property; doc wrapping; whitespace cleanup. |
| src/Modules/ProductCatalog/Entities/Category.cs | Moved Id property; trailing whitespace cleanup. |
| src/Modules/ProductCatalog/Configurations/ProductDataLinkConfiguration.cs | Removed unused using; trailing whitespace cleanup. |
| src/Modules/ProductCatalog/Configurations/ProductConfiguration.cs | Removed unused using; doc wrapping. |
| src/Modules/ProductCatalog/Configurations/ProductCategoryStatsConfiguration.cs | Formatting + added max length mapping for CategoryName. |
| src/Modules/ProductCatalog/Configurations/CategoryConfiguration.cs | Removed unused using; trailing whitespace cleanup. |
| src/Modules/ProductCatalog/Common/Events/CacheTags.cs | Minor whitespace formatting. |
| src/Modules/ProductCatalog/Common/Errors/ProductCatalogDomainErrors.cs | Converted expression-bodied member to block body. |
| src/Modules/ProductCatalog/Common/Errors/ErrorCatalog.cs | Minor whitespace formatting. |
| src/Modules/ProductCatalog/Common/Errors/DomainErrors.cs | Converted expression-bodied members to block bodies; formatting cleanup. |
| src/Modules/Notifications/StoredProcedures/Sql/claim_retryable_failed_emails_v1_up.sql | SQL formatting changes. |
| src/Modules/Notifications/StoredProcedures/Sql/claim_expired_failed_emails_v1_up.sql | SQL formatting changes. |
| src/Modules/Notifications/StoredProcedures/ClaimRetryableFailedEmailsProcedure.cs | Removed unused usings; block-bodied ToSql. |
| src/Modules/Notifications/StoredProcedures/ClaimExpiredFailedEmailsProcedure.cs | Removed unused usings; block-bodied ToSql. |
| src/Modules/Notifications/Services/MailKitEmailSender.cs | Reordered fields; moved DisposeAsync; minor formatting adjustments. |
| src/Modules/Notifications/Services/FluidEmailTemplateRenderer.cs | Minor formatting + added braces around throw path. |
| src/Modules/Notifications/Services/FailedEmailStore.cs | Removed unused using; minor formatting adjustments. |
| src/Modules/Notifications/Services/FailedEmailErrorNormalizer.cs | Doc wrapping + simplified braces. |
| src/Modules/Notifications/Services/EmailSendingBackgroundService.cs | Simplified base type reference; doc wrapping; removed unused usings. |
| src/Modules/Notifications/Services/EmailRetryService.cs | Reordered fields; minor formatting adjustments. |
| src/Modules/Notifications/Services/EmailRetryRecurringJobRegistration.cs | Formatting + explicit type in return. |
| src/Modules/Notifications/Services/EmailRetryRecurringJob.cs | Reordered fields; converted expression-bodied to block body. |
| src/Modules/Notifications/Services/ChannelEmailQueue.cs | Simplified base type reference; removed unused usings. |
| src/Modules/Notifications/Repositories/FailedEmailRepository.cs | Removed unused usings; doc wrapping; new() style. |
| src/Modules/Notifications/Persistence/NotificationsDbContext.cs | Removed unused usings. |
| src/Modules/Notifications/Persistence/FailedEmailConfiguration.cs | Doc wrapping + set HtmlBody column type to text. |
| src/Modules/Notifications/NotificationsRuntimeBridge.cs | Updated Polly retry options type usage + imports. |
| src/Modules/Notifications/NotificationsModule.cs | Removed unused using. |
| src/Modules/Notifications/Features/SendUserRoleChangedEmail/UserRoleChangedEmailHandler.cs | Removed unused usings; minor typing cleanup. |
| src/Modules/Notifications/Features/SendUserRegisteredEmail/UserRegisteredEmailHandler.cs | Removed unused usings; minor typing cleanup. |
| src/Modules/Notifications/Features/SendTenantInvitationEmail/TenantInvitationEmailHandler.cs | Anonymous object property inference refactor + positional arg tweak. |
| src/Modules/Notifications/Domain/IFailedEmailRepository.cs | Removed unused usings; added explicit public on interface members; whitespace cleanup. |
| src/Modules/Notifications/Domain/FailedEmail.cs | Moved Id property; trailing whitespace cleanup. |
| src/Modules/Notifications/Contracts/IFailedEmailStore.cs | Added explicit public on interface members + multiline signature. |
| src/Modules/Notifications/Contracts/IEmailTemplateRenderer.cs | Added explicit public on interface members + multiline signature. |
| src/Modules/Notifications/Contracts/IEmailSender.cs | Added explicit public on interface member. |
| src/Modules/Notifications/Contracts/IEmailRetryService.cs | Added explicit public on interface members + multiline signatures. |
| src/Modules/Notifications/Contracts/IEmailQueue.cs | Removed unused usings; whitespace cleanup. |
| src/Modules/Notifications/Contracts/EmailOptions.cs | Trailing whitespace cleanup. |
| src/Modules/Notifications/Contracts/EmailMessage.cs | Trailing whitespace cleanup. |
| src/Modules/Identity/ValueObjects/TenantCode.cs | Converted expression-bodied members to block bodies; reordered ctor/property. |
| src/Modules/Identity/ValueObjects/Email.cs | Added using System.Net.Mail;; converted expression-bodied members to block bodies; doc wrapping. |
| src/Modules/Identity/SoftDelete/TenantSoftDeleteCascadeRule.cs | Removed unused usings; converted expression-bodied member to block body. |
| src/Modules/Identity/Security/TenantClaimValidator.cs | Converted expression-bodied members to block bodies; minor formatting changes. |
| src/Modules/Identity/Security/Tenant/UserProvisioningService.cs | Using order + field order cleanup. |
| src/Modules/Identity/Security/SecureTokenGenerator.cs | Added using System.Text; and simplified Encoding reference. |
| src/Modules/Identity/Security/Keycloak/KeycloakUrlHelper.cs | Converted expression-bodied members to block bodies. |
| src/Modules/Identity/Security/Keycloak/KeycloakTokenResponse.cs | Trailing whitespace cleanup. |
| src/Modules/Identity/Security/Keycloak/KeycloakClaimMapper.cs | Explicit typing for role string. |
| src/Modules/Identity/Security/Keycloak/KeycloakAdminTokenProvider.cs | Field order cleanup; explicit Dispose method; added braces for throw path. |
| src/Modules/Identity/Security/Keycloak/KeycloakAdminTokenHandler.cs | Explicit typing for token string. |
| src/Modules/Identity/Security/Keycloak/KeycloakAdminService.cs | Added using System.Net;; simplified status code reference; minor typing cleanup. |
| src/Modules/Identity/Security/DragonflyTicketStore.cs | Converted expression-bodied member to block body. |
| src/Modules/Identity/Security/CookieSessionRefresher.cs | Formatting + added braces around conditional assignment; refactored helpers to block bodies. |
| src/Modules/Identity/Repositories/UserRepository.cs | Converted expression-bodied members to block bodies. |
| src/Modules/Identity/Repositories/TenantRepository.cs | Moved GetByIdAsync override earlier; minor formatting. |
| src/Modules/Identity/Repositories/TenantInvitationRepository.cs | Converted expression-bodied members to block bodies + added closing brace. |
| src/Modules/Identity/Repositories/PostgresTenantCodeConflictDetector.cs | Converted expression-bodied member to block body + brace fixes. |
| src/Modules/Identity/Persistence/IdentityDbContext.cs | Removed unused using; trailing whitespace cleanup. |
| src/Modules/Identity/Persistence/EntityNormalization/AppUserEntityNormalizationService.cs | Removed unused usings; trailing whitespace cleanup. |
| src/Modules/Identity/Persistence/Configurations/TenantInvitationConfiguration.cs | Trailing whitespace cleanup. |
| src/Modules/Identity/Persistence/Configurations/TenantConfiguration.cs | Trailing whitespace cleanup. |
| src/Modules/Identity/Persistence/Configurations/AppUserConfiguration.cs | Trailing whitespace cleanup. |
| src/Modules/Identity/Persistence/AuthBootstrapSeeder.cs | Converted expression-bodied members to block bodies; removed unused using. |
| src/Modules/Identity/Logging/IdentityInfrastructureLogs.cs | Trailing whitespace cleanup. |
| src/Modules/Identity/Interfaces/IUserRepository.cs | Removed unused usings; added explicit public on interface members; multiline signature. |
| src/Modules/Identity/Interfaces/ITenantRepository.cs | Removed unused usings; trailing whitespace cleanup. |
| src/Modules/Identity/Interfaces/ITenantInvitationRepository.cs | Removed unused usings; added explicit public on interface members; multiline signatures. |
| src/Modules/Identity/IdentityModule.cs | Simplified generic marker reference (IdentityDbMarker). |
| src/Modules/Identity/IdentityDbMarker.cs | Trailing whitespace cleanup. |
| src/Modules/Identity/Identity.csproj | Formatted PackageReference XML for readability. |
| src/Modules/Identity/Identity.Domain.GlobalUsings.cs | Trailing whitespace cleanup. |
| src/Modules/Identity/Handlers/CleanupExpiredInvitationsHandler.cs | Simplified braces; potential brace/indent cleanup. |
| src/Modules/Identity/Features/V1/UsersController.cs | Multiline generic invocation + signature formatting; positional arg tweak. |
| src/Modules/Identity/Features/V1/TenantsController.cs | Multiline generic invocation + signature formatting. |
| src/Modules/Identity/Features/V1/BffController.cs | Converted expression-bodied member to block body; simplified type qualification. |
| src/Modules/Identity/Features/User/Validation/UserFilterValidator.cs | Removed unused usings + doc wrapping. |
| src/Modules/Identity/Features/User/Validation/UpdateUserRequestValidator.cs | Removed unused usings. |
| src/Modules/Identity/Features/User/Validation/CreateUserRequestValidator.cs | Removed unused usings. |
| src/Modules/Identity/Features/User/Validation/ChangeUserRoleRequestValidator.cs | Removed unused usings + doc wrapping. |
| src/Modules/Identity/Features/User/UserValidationHelper.cs | Removed unused usings; explicit typing. |
| src/Modules/Identity/Features/User/UserSortFields.cs | Removed unused usings. |
| src/Modules/Identity/Features/User/Specifications/UserFilterSpecification.cs | Removed unused usings; doc wrapping. |
| src/Modules/Identity/Features/User/Specifications/UserFilterCriteria.cs | Explicit typing. |
| src/Modules/Identity/Features/User/Specifications/UserByUsernameSpecification.cs | Removed unused using. |
| src/Modules/Identity/Features/User/Specifications/UserByIdSpecification.cs | Removed unused usings; doc wrapping. |
| src/Modules/Identity/Features/User/Specifications/UserByEmailSpecification.cs | Removed unused using; doc wrapping. |
| src/Modules/Identity/Features/User/Queries/GetUsersQuery.cs | Removed unused usings; kept required specification using. |
| src/Modules/Identity/Features/User/Queries/GetUserByIdQuery.cs | Removed unused usings; kept required specification using. |
| src/Modules/Identity/Features/User/Mappings/UserMappings.cs | Doc wrapping + converted expression-bodied member to block body. |
| src/Modules/Identity/Features/User/DTOs/UserResponse.cs | Removed unused usings. |
| src/Modules/Identity/Features/User/DTOs/UserFilter.cs | Removed unused usings; doc wrapping. |
| src/Modules/Identity/Features/User/DTOs/UpdateUserRequest.cs | Removed unused using. |
| src/Modules/Identity/Features/User/DTOs/RequestPasswordResetRequest.cs | Removed unused using. |
| src/Modules/Identity/Features/User/DTOs/CreateUserRequest.cs | Removed unused using. |
| src/Modules/Identity/Features/User/DTOs/ChangeUserRoleRequest.cs | Removed unused using. |
| src/Modules/Identity/Features/User/Commands/UpdateUserCommand.cs | Removed unused using. |
| src/Modules/Identity/Features/User/Commands/KeycloakPasswordResetCommand.cs | Removed unused using. |
| src/Modules/Identity/Features/User/Commands/DeleteUserCommand.cs | Removed unused using. |
| src/Modules/Identity/Features/User/Commands/CreateUserCommand.cs | Removed unused using; minor whitespace. |
| src/Modules/Identity/Features/User/Commands/ChangeUserRoleCommand.cs | Removed unused using. |
| src/Modules/Identity/Features/TenantInvitation/Validation/CreateTenantInvitationRequestValidator.cs | Removed unused usings + doc wrapping. |
| src/Modules/Identity/Features/TenantInvitation/Specifications/TenantInvitationFilterSpecification.cs | Removed unused using; doc wrapping. |
| src/Modules/Identity/Features/TenantInvitation/Queries/GetTenantInvitationsQuery.cs | Removed unused usings; kept required specification using. |
| src/Modules/Identity/Features/TenantInvitation/Mappings/TenantInvitationMappings.cs | Doc wrapping + converted expression-bodied member to block body. |
| src/Modules/Identity/Features/TenantInvitation/DTOs/TenantInvitationResponse.cs | Removed unused usings. |
| src/Modules/Identity/Features/TenantInvitation/DTOs/TenantInvitationFilter.cs | Removed unused usings. |
| src/Modules/Identity/Features/TenantInvitation/DTOs/CreateTenantInvitationRequest.cs | Removed unused using. |
| src/Modules/Identity/Features/TenantInvitation/DTOs/AcceptInvitationRequest.cs | Removed unused using. |
| src/Modules/Identity/Features/TenantInvitation/Commands/RevokeTenantInvitationCommand.cs | Removed unused using. |
| src/Modules/Identity/Features/TenantInvitation/Commands/CreateTenantInvitationCommand.cs | Removed unused using; added braces around early return. |
| src/Modules/Identity/Features/Tenant/Validation/TenantFilterValidator.cs | Removed unused usings. |
| src/Modules/Identity/Features/Tenant/Validation/CreateTenantRequestValidator.cs | Removed unused usings. |
| src/Modules/Identity/Features/Tenant/TenantSortFields.cs | Removed unused using. |
| src/Modules/Identity/Features/Tenant/Specifications/TenantSpecification.cs | Removed unused using; doc wrapping. |
| src/Modules/Identity/Features/Tenant/Specifications/TenantFilterCriteria.cs | Removed unused usings; doc wrapping. |
| src/Modules/Identity/Features/Tenant/Specifications/TenantByIdSpecification.cs | Removed unused using; doc wrapping. |
| src/Modules/Identity/Features/Tenant/Queries/GetTenantsQuery.cs | Removed unused usings; kept required specification using. |
| src/Modules/Identity/Features/Tenant/Queries/GetTenantByIdQuery.cs | Removed unused usings; kept required specification using. |
| src/Modules/Identity/Features/Tenant/Mappings/TenantMappings.cs | Doc wrapping + converted expression-bodied member to block body. |
| src/Modules/Identity/Features/Tenant/ITenantCodeConflictDetector.cs | Added explicit public on interface member. |
| src/Modules/Identity/Features/Tenant/DTOs/TenantResponse.cs | Removed unused using. |
| src/Modules/Identity/Features/Tenant/DTOs/TenantFilter.cs | Removed unused usings. |
| src/Modules/Identity/Features/Tenant/DTOs/CreateTenantRequest.cs | DataAnnotations formatting. |
| src/Modules/Identity/Features/Tenant/Commands/DeleteTenantCommand.cs | Removed unused using. |
| src/Modules/Identity/Features/Tenant/Commands/CreateTenantCommand.cs | Removed unused using. |
| src/Modules/Identity/Features/Bff/DTOs/BffUserResponse.cs | Doc wrapping; trailing whitespace cleanup. |
| src/Modules/Identity/Enums/UserRole.cs | Trailing whitespace cleanup. |
| src/Modules/Identity/Enums/InvitationStatus.cs | Trailing whitespace cleanup. |
| src/Modules/Identity/Entities/TenantInvitation.cs | Moved Id; converted expression-bodied members to block bodies; doc wrapping. |
| src/Modules/Identity/Entities/Tenant.cs | Moved Id; converted expression-bodied methods to block bodies. |
| src/Modules/Identity/Entities/AppUser.cs | Moved Id; converted expression-bodied member to block body. |
| src/Modules/Identity/Common/TenantInvitationOptions.cs | Trailing whitespace cleanup. |
| src/Modules/Identity/Common/SystemIdentityOptions.cs | Removed unused using. |
| src/Modules/Identity/Common/Security/StaticRolePermissionMap.cs | Converted expression-bodied members to block bodies; explicit typing. |
| src/Modules/Identity/Common/Security/IUserProvisioningService.cs | Added explicit public on interface member. |
| src/Modules/Identity/Common/Security/IRolePermissionMap.cs | Added explicit public on interface members. |
| src/Modules/Identity/Common/Security/IKeycloakAdminService.cs | Added explicit public on interface members + multiline signatures. |
| src/Modules/Identity/Common/KeycloakOptions.cs | Trailing whitespace cleanup. |
| src/Modules/Identity/Common/IdentityDomainErrors.cs | Converted expression-bodied members to block bodies. |
| src/Modules/Identity/Common/IdentityApplicationLogs.cs | Trailing whitespace cleanup. |
| src/Modules/Identity/Common/ErrorCatalog.cs | Minor whitespace formatting. |
| src/Modules/Identity/Common/Email/ISecureTokenGenerator.cs | Added explicit public on interface members. |
| src/Modules/Identity/Common/DomainErrors.cs | Converted expression-bodied members to block bodies; formatting cleanup. |
| src/Modules/Identity/Common/CorsOptions.cs | Trailing whitespace cleanup. |
| src/Modules/Identity/Common/CacheTags.cs | Trailing whitespace cleanup. |
| src/Modules/Identity/Common/BootstrapTenantOptions.cs | Trailing whitespace cleanup. |
| src/Modules/FileStorage/Services/LocalFileStorageService.cs | Explicit typing + doc wrapping; minor formatting. |
| src/Modules/FileStorage/Features/FilesController.cs | Removed unused usings. |
| src/Modules/FileStorage/Features/FileUploadRequest.cs | Using order + trailing whitespace cleanup. |
| src/Modules/FileStorage/Errors/ErrorCatalog.cs | Trailing whitespace cleanup. |
| src/Modules/FileStorage/Errors/DomainErrors.cs | Converted expression-bodied members to block bodies; formatting cleanup. |
| src/Modules/FileStorage/Domain/StoredFile.cs | Moved Id; trailing whitespace cleanup. |
| src/Modules/FileStorage/Domain/IStoredFileRepository.cs | Doc wrapping + removed unused using. |
| src/Modules/FileStorage/Domain/FileStorageDbMarker.cs | Trailing whitespace cleanup. |
| src/Modules/FileStorage/Contracts/UploadFileRequest.cs | Doc wrapping; trailing whitespace cleanup. |
| src/Modules/FileStorage/Contracts/IFileStorageService.cs | Added explicit public on interface members; multiline signature. |
| src/Modules/FileStorage/Contracts/FileUploadResponse.cs | Trailing whitespace cleanup. |
| src/Modules/FileStorage/Contracts/FileStorageOptions.cs | Trailing whitespace cleanup. |
| src/Modules/FileStorage/Contracts/DownloadFileRequest.cs | Trailing whitespace cleanup. |
| src/Modules/Chatting/Features/SseController.cs | Removed stray blank line; trailing whitespace cleanup. |
| src/Modules/Chatting/Features/GetNotificationStream/SseStreamRequest.cs | Trailing whitespace cleanup. |
| src/Modules/Chatting/Features/GetNotificationStream/SseNotificationItem.cs | Trailing whitespace cleanup. |
| src/Modules/Chatting/Features/GetNotificationStream/GetNotificationStreamQuery.cs | Trailing whitespace cleanup. |
| src/Modules/BackgroundJobs/Validation/BackgroundJobsOptionsValidator.cs | Removed unused using; minor formatting. |
| src/Modules/BackgroundJobs/TickerQ/TickerQSchedulerDbContextFactory.cs | Simplified AddJsonFile optional arg usage. |
| src/Modules/BackgroundJobs/TickerQ/TickerQSchedulerDbContext.cs | Simplified foreach typing + imports; formatting cleanup. |
| src/Modules/BackgroundJobs/TickerQ/TickerQRecurringJobRegistrar.cs | Removed unused usings; field order. |
| src/Modules/BackgroundJobs/TickerQ/RecurringJobRegistrations/ReindexRecurringJobRegistration.cs | Removed unused usings; explicit return type construction. |
| src/Modules/BackgroundJobs/TickerQ/RecurringJobRegistrations/ExternalSyncRecurringJobRegistration.cs | Removed unused usings; explicit return type construction. |
| src/Modules/BackgroundJobs/TickerQ/RecurringJobRegistrations/CleanupRecurringJobRegistration.cs | Removed unused usings; explicit return type construction. |
| src/Modules/BackgroundJobs/TickerQ/Jobs/ReindexRecurringJob.cs | Removed unused usings; converted expression-bodied to block body. |
| src/Modules/BackgroundJobs/TickerQ/Jobs/ExternalSyncRecurringJob.cs | Removed unused usings; converted expression-bodied to block body. |
| src/Modules/BackgroundJobs/TickerQ/Jobs/CleanupRecurringJob.cs | Removed unused usings; converted expression-bodied to block body. |
| src/Modules/BackgroundJobs/TickerQ/DragonflyDistributedJobCoordinator.cs | Minor formatting; converted expression-bodied helper to block body; minor param naming cleanup. |
| src/Modules/BackgroundJobs/StoredProcedures/GetIndexBloatPercentProcedure.cs | Converted expression-bodied ToSql to block body. |
| src/Modules/BackgroundJobs/StoredProcedures/GetFtsIndexNamesProcedure.cs | Converted expression-bodied ToSql to block body. |
| src/Modules/BackgroundJobs/Services/SoftDeleteCleanupStrategy.cs | Removed unused using. |
| src/Modules/BackgroundJobs/Services/JobProcessingBackgroundService.cs | Field order cleanup. |
| src/Modules/BackgroundJobs/Services/CleanupService.cs | Field order cleanup. |
| src/Modules/BackgroundJobs/Repositories/JobExecutionRepository.cs | Removed unused using. |
| src/Modules/BackgroundJobs/Persistence/JobExecutionConfiguration.cs | Configured several large-string columns as text. |
| src/Modules/BackgroundJobs/Persistence/BackgroundJobsDbContext.cs | Removed unused usings. |
| src/Modules/BackgroundJobs/Features/SubmitJob/SubmitJobRequest.cs | Doc wrapping. |
| src/Modules/BackgroundJobs/Features/SubmitJob/SubmitJobCommand.cs | Error creation formatting + reference cleanup. |
| src/Modules/BackgroundJobs/Features/JobsController.cs | Removed unused usings. |
| src/Modules/BackgroundJobs/Features/GetJobStatus/JobStatusResponse.cs | Doc wrapping. |
| src/Modules/BackgroundJobs/Domain/JobStatus.cs | Trailing whitespace cleanup. |
| src/Modules/BackgroundJobs/Domain/JobMappings.cs | Converted expression-bodied member to block body; doc wrapping. |
| src/Modules/BackgroundJobs/Domain/JobExecution.cs | Moved Id; doc wrapping; trailing whitespace cleanup. |
| src/Modules/BackgroundJobs/Domain/IJobExecutionRepository.cs | Doc wrapping. |
| src/Modules/BackgroundJobs/Domain/BackgroundJobsDbMarker.cs | Trailing whitespace cleanup. |
| src/Modules/BackgroundJobs/Contracts/IReindexService.cs | Added explicit public on interface member. |
| src/Modules/BackgroundJobs/Contracts/IJobQueue.cs | Trailing whitespace cleanup. |
| src/Modules/BackgroundJobs/Contracts/IExternalIntegrationSyncService.cs | Added explicit public on interface member. |
| src/Modules/BackgroundJobs/Contracts/ICleanupService.cs | Added explicit public on interface members; multiline signatures. |
| src/Modules/BackgroundJobs/BackgroundJobsRuntimeBridge.cs | Refactored options registration call style; removed unused usings. |
| src/Modules/BackgroundJobs/BackgroundJobsModule.cs | Removed unused using. |
| src/APITemplate/Api/Extensions/WolverineTypeExtensions.cs | Removed redundant braces; minor cleanup. |
| src/APITemplate/Api/Extensions/WolverineHandlerChainExtensions.cs | Converted expression-bodied member to block body. |
| src/APITemplate/Api/Extensions/Startup/DatabaseStartupExtensions.cs | Use Npgsql PostgresException import + simplified catch filter. |
| src/APITemplate/Api/Extensions/Startup/ApplicationBuilderExtensions.cs | Converted expression-bodied helper to block body. |
| src/APITemplate/Api/Extensions/ObservabilityServiceCollectionExtensions.cs | Expanded option initialization + minor OpenTelemetry call refactor. |
| src/APITemplate/Api/Extensions/ApplicationCompositionServiceCollectionExtensions.cs | Removed redundant braces; minor cleanup. |
| src/APITemplate/Api/Extensions/ApiServiceCollectionExtensions.cs | Expanded options initialization; minor health check call signature tweak. |
| src/APITemplate/Api/Api/OpenApi/ProblemDetailsOpenApiTransformer.cs | Fixed foreach typing + added braces (structure clarity). |
| src/APITemplate/Api/Api/OpenApi/OpenApiErrorResponseHelper.cs | Added braces + explicit typing; minor object initialization simplification. |
| src/APITemplate/Api/Api/OpenApi/HealthCheckOpenApiDocumentTransformer.cs | Minor OpenAPI tag initialization refactor. |
| src/APITemplate/Api/Api/OpenApi/BearerSecuritySchemeDocumentTransformer.cs | Minor OpenAPI reference ctor usage; field order. |
| src/APITemplate/Api/Api/Middleware/RequestContextMiddleware.cs | Explicit typing + key-value pair construction change; brace cleanup. |
| src/APITemplate/Api/Api/Middleware/CsrfValidationMiddleware.cs | Added relevant usings; simplified fully-qualified type names. |
| src/APITemplate/Api/Api/ExceptionHandling/ApiProblemDetailsOptions.cs | Removed unused usings; explicit typing. |
| src/APITemplate/Api/Api/ExceptionHandling/ApiExceptionHandler.cs | Removed unused using; explicit typing; added braces around else logging block; helper block body. |
| src/APITemplate/Api/Api/Cache/TenantAwareOutputCachePolicy.cs | Converted expression-bodied members to block bodies; brace cleanup. |
| src/APITemplate/Api/Api/Cache/OutputCacheInvalidationService.cs | Converted expression-bodied member to block body; explicit typing. |
| src/APITemplate/Api/Api/Cache/IOutputCacheInvalidationService.cs | Added explicit public on interface members. |
| src/APITemplate/Api/Api/Cache/CacheInvalidationHandler.cs | Converted expression-bodied member to block body. |
| src/APITemplate/Api/Api/Authorization/PermissionPolicyProvider.cs | Converted expression-bodied ctor + members to block bodies; field order. |
| infrastructure/observability/grafana/dashboards/apitemplate-overview.json | JSON formatting/pretty-print changes. |
| infrastructure/keycloak/realms/api-template-realm.json | JSON formatting/pretty-print changes. |
| docs/README.md | Wrapped text + adjusted table separator formatting. |
| TODO.md | Wrapped long lines and improved markdown formatting. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+6
to
+10
| | Guide | What it covers | | ||
| |-------------------------------------------------|-------------------------------------------------------------------------------------------| | ||
| | [GraphQL Endpoint](graphql-endpoint.md) | Create a type, query, mutation, and DataLoader with HotChocolate | | ||
| | [REST Endpoint](rest-endpoint.md) | Full workflow: entity → DTO → validator → Wolverine handler → controller | | ||
| | [Endpoint Showcases](endpoint-showcase.md) | SSE streaming, file upload/download, async jobs, batch, idempotency, JSON Patch, webhooks | |
There was a problem hiding this comment.
The markdown table has an extra leading pipe (|| ...), which creates an empty first column and can break table rendering (especially the separator row). Consider rewriting the header/separator/rows to use the standard 2-column format (| Guide | What it covers | + | --- | --- |) so it renders consistently across markdown viewers.
| html, | ||
| EmailTemplateNames.TenantInvitation, | ||
| Retryable: true | ||
| true |
There was a problem hiding this comment.
Passing true positionally into EmailMessage reduces readability and becomes fragile if the record parameter order changes. Prefer using the named argument here (e.g., Retryable: true) to make intent explicit.
Suggested change
| true | |
| Retryable: true |
| { | ||
| /// <summary>Persists a new failed-email record to the store.</summary> | ||
| Task AddAsync(FailedEmail failedEmail, CancellationToken ct = default); | ||
| public Task AddAsync(FailedEmail failedEmail, CancellationToken ct = default); |
There was a problem hiding this comment.
Interface members are implicitly public in C#. Adding explicit public on interface method declarations is redundant and creates noise across many files. Unless there’s a specific reason to rely on explicit accessibility modifiers in interfaces, consider removing the public keywords to match conventional style and reduce diff churn.
| /// and returns them for processing. | ||
| /// </summary> | ||
| Task<List<FailedEmail>> ClaimRetryableBatchAsync( | ||
| public Task<List<FailedEmail>> ClaimRetryableBatchAsync( |
There was a problem hiding this comment.
Interface members are implicitly public in C#. Adding explicit public on interface method declarations is redundant and creates noise across many files. Unless there’s a specific reason to rely on explicit accessibility modifiers in interfaces, consider removing the public keywords to match conventional style and reduce diff churn.
| /// allowing stale claims to be retried. | ||
| /// </summary> | ||
| Task<List<FailedEmail>> ClaimExpiredBatchAsync( | ||
| public Task<List<FailedEmail>> ClaimExpiredBatchAsync( |
There was a problem hiding this comment.
Interface members are implicitly public in C#. Adding explicit public on interface method declarations is redundant and creates noise across many files. Unless there’s a specific reason to rely on explicit accessibility modifiers in interfaces, consider removing the public keywords to match conventional style and reduce diff churn.
Comment on lines
+39
to
+42
| public Task UpdateAsync(FailedEmail failedEmail, CancellationToken ct = default); | ||
|
|
||
| /// <summary>Permanently removes a successfully processed failed-email record from the store.</summary> | ||
| Task DeleteAsync(FailedEmail failedEmail, CancellationToken ct = default); | ||
| public Task DeleteAsync(FailedEmail failedEmail, CancellationToken ct = default); |
There was a problem hiding this comment.
Interface members are implicitly public in C#. Adding explicit public on interface method declarations is redundant and creates noise across many files. Unless there’s a specific reason to rely on explicit accessibility modifiers in interfaces, consider removing the public keywords to match conventional style and reduce diff churn.
…controllers - Refactor ToCreatedResult method calls in multiple controllers to include action name as a parameter for improved clarity. - Adjust ApiExceptionHandler to remove nullable types for error details, enhancing type safety.
- Deleted the legacy `APITemplate.Api` project files, including README, project configuration, Dockerfile, and various source files. - This cleanup is part of the transition to a new architecture and modular design.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the project's .editorconfig to standardize formatting, cleans up the solution file structure, and refines the README documentation. Additionally, it improves code consistency by updating various files to use block-scoped namespaces and braces, and cleans up redundant using directives. No review comments were provided for this pull request.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 296 out of 1186 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…itory - Removed redundant access modifiers from method declarations in IFailedEmailRepository for improved readability. - Updated TenantInvitationEmailHandler to use named parameters for clarity in method calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.