refactor: scrub Python2 compatibility fossils#206
Merged
Conversation
Removes compiler warning for unused functions.
Remove the local '_compat.h' header where they were defined, replacing imports of it everwhere with 'Python.h'. Note that the unrelated '_compat.h' header in the 'include/persistent/persistent/' directory is still in place. No C header or module imports it directly, and none uses any macros defined in it indirectly.
davisagli
approved these changes
Jun 3, 2024
Member
Author
|
I don't grok the Coveralls failures, but they appear to be complaining that |
Member
|
@tseaver It's not the first time I've seen confusing reports from coveralls |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
long_long/ulong_longhelpers. Silences compiler warning for unused functions._compat.hheader where they were defined, replacing includes of it everwhere with#include "Python.h".Note that the unrelated
include/persistent/persistent/'compat.hheader in the directory is still in place. No C header or module imports it directly, and none uses any macros defined in it indirectly.This work is in preparation for adding PEP 489 multi-phase module initialization, including compatibility with the changes to
persistentin zopefoundation/persistent#204. bit does not yet expect (or require) that PR to be merged.