refactor graphql objects to use class based approach#1665
Merged
Conversation
yuenmichelle1
approved these changes
Dec 30, 2025
Contributor
|
Looks good as far as I can tell. Testing locally it looks good. I didnt really test any mutation (other than the check to see if they can still be called), but I don't think anyone was really using those. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor graphql objects to use class based approach and remove restriction on gem
'GraphQL::ObjectType.define will be removed in GraphQL-Ruby 2.0; use a class-based definition instead. See https://graphql-ruby.org/schema/class_based_api.html. -> called from /app/app/models/workflow.rb:4:inclass:Workflow'GraphQL::Schema.define will be removed in GraphQL-Ruby 2.0; use a class-based definition instead. See https://graphql-ruby.org/schema/class_based_api.html.
-> called from /app/app/graphql/caesar_schema.rb:1:in
<main>' GraphQL::ObjectType.define will be removed in GraphQL-Ruby 2.0; use a class-based definition instead. See https://graphql-ruby.org/schema/class_based_api.html. -> called from /app/app/graphql/query_root.rb:1:inGraphQL::ObjectType.define will be removed in GraphQL-Ruby 2.0; use a class-based definition instead. See https://graphql-ruby.org/schema/class_based_api.html.
-> called from /app/app/graphql/mutation_root.rb:1:in
<main>' GraphQL::ObjectType.define will be removed in GraphQL-Ruby 2.0; use a class-based definition instead. See https://graphql-ruby.org/schema/class_based_api.html. -> called from /app/app/models/credential.rb:2:inclass:Credential'GraphQL::ScalarType.define will be removed in GraphQL-Ruby 2.0; use a class-based definition instead. See https://graphql-ruby.org/schema/class_based_api.html.
-> called from /app/app/graphql/types/time_type.rb:1:in
<main>' GraphQL::ObjectType.define will be removed in GraphQL-Ruby 2.0; use a class-based definition instead. See https://graphql-ruby.org/schema/class_based_api.html. -> called from /app/app/models/extract.rb:2:inclass:Extract'GraphQL::ObjectType.define will be removed in GraphQL-Ruby 2.0; use a class-based definition instead. See https://graphql-ruby.org/schema/class_based_api.html.
-> called from /app/app/models/subject_reduction.rb:4:in
<class:SubjectReduction>' GraphQL::ObjectType.define will be removed in GraphQL-Ruby 2.0; use a class-based definition instead. See https://graphql-ruby.org/schema/class_based_api.html. -> called from /app/app/models/subject_action.rb:2:inclass:SubjectAction'GraphQL::ObjectType.define will be removed in GraphQL-Ruby 2.0; use a class-based definition instead. See https://graphql-ruby.org/schema/class_based_api.html.
-> called from /app/app/models/user_reduction.rb:4:in
<class:UserReduction>' GraphQL::ObjectType.define will be removed in GraphQL-Ruby 2.0; use a class-based definition instead. See https://graphql-ruby.org/schema/class_based_api.html. -> called from /app/app/models/user_action.rb:2:inclass:UserAction'GraphQL::EnumType.define will be removed in GraphQL-Ruby 2.0; use a class-based definition instead. See https://graphql-ruby.org/schema/class_based_api.html.
-> called from /app/app/models/data_request.rb:3:in
<class:DataRequest>' GraphQL::EnumType.define will be removed in GraphQL-Ruby 2.0; use a class-based definition instead. See https://graphql-ruby.org/schema/class_based_api.html. -> called from /app/app/models/data_request.rb:13:inclass:DataRequest'GraphQL::ObjectType.define will be removed in GraphQL-Ruby 2.0; use a class-based definition instead. See https://graphql-ruby.org/schema/class_based_api.html.
-> called from /app/app/models/data_request.rb:26:in
<class:DataRequest>' GraphQL::ScalarType.define will be removed in GraphQL-Ruby 2.0; use a class-based definition instead. See https://graphql-ruby.org/schema/class_based_api.html. -> called from /app/app/graphql/types/json_type.rb:3:in'GraphQL::EnumType.define will be removed in GraphQL-Ruby 2.0; use a class-based definition instead. See https://graphql-ruby.org/schema/class_based_api.html.
-> called from /app/app/graphql/types/action_status_type.rb:1:in
<main>'Resolving console warnings in caesar.
See here
And here