Skip to content

refactor graphql objects to use class based approach#1665

Merged
Tooyosi merged 5 commits intomasterfrom
migrate-graphql
Jan 2, 2026
Merged

refactor graphql objects to use class based approach#1665
Tooyosi merged 5 commits intomasterfrom
migrate-graphql

Conversation

@Tooyosi
Copy link
Copy Markdown
Collaborator

@Tooyosi Tooyosi commented Dec 5, 2025

refactor graphql objects to use class based approach and remove restriction on gem

GraphQL::ObjectType.define will be removed in GraphQL-Ruby 2.0; use a class-based definition instead. See https://graphql-ruby.org/schema/class_based_api.html. -> called from /app/app/models/workflow.rb:4:in class:Workflow'
GraphQL::Schema.define will be removed in GraphQL-Ruby 2.0; use a class-based definition instead. See https://graphql-ruby.org/schema/class_based_api.html.
-> called from /app/app/graphql/caesar_schema.rb:1:in <main>' GraphQL::ObjectType.define will be removed in GraphQL-Ruby 2.0; use a class-based definition instead. See https://graphql-ruby.org/schema/class_based_api.html. -> called from /app/app/graphql/query_root.rb:1:in

'
GraphQL::ObjectType.define will be removed in GraphQL-Ruby 2.0; use a class-based definition instead. See https://graphql-ruby.org/schema/class_based_api.html.
-> called from /app/app/graphql/mutation_root.rb:1:in <main>' GraphQL::ObjectType.define will be removed in GraphQL-Ruby 2.0; use a class-based definition instead. See https://graphql-ruby.org/schema/class_based_api.html. -> called from /app/app/models/credential.rb:2:in class:Credential'
GraphQL::ScalarType.define will be removed in GraphQL-Ruby 2.0; use a class-based definition instead. See https://graphql-ruby.org/schema/class_based_api.html.
-> called from /app/app/graphql/types/time_type.rb:1:in <main>' GraphQL::ObjectType.define will be removed in GraphQL-Ruby 2.0; use a class-based definition instead. See https://graphql-ruby.org/schema/class_based_api.html. -> called from /app/app/models/extract.rb:2:in class:Extract'
GraphQL::ObjectType.define will be removed in GraphQL-Ruby 2.0; use a class-based definition instead. See https://graphql-ruby.org/schema/class_based_api.html.
-> called from /app/app/models/subject_reduction.rb:4:in <class:SubjectReduction>' GraphQL::ObjectType.define will be removed in GraphQL-Ruby 2.0; use a class-based definition instead. See https://graphql-ruby.org/schema/class_based_api.html. -> called from /app/app/models/subject_action.rb:2:in class:SubjectAction'
GraphQL::ObjectType.define will be removed in GraphQL-Ruby 2.0; use a class-based definition instead. See https://graphql-ruby.org/schema/class_based_api.html.
-> called from /app/app/models/user_reduction.rb:4:in <class:UserReduction>' GraphQL::ObjectType.define will be removed in GraphQL-Ruby 2.0; use a class-based definition instead. See https://graphql-ruby.org/schema/class_based_api.html. -> called from /app/app/models/user_action.rb:2:in class:UserAction'
GraphQL::EnumType.define will be removed in GraphQL-Ruby 2.0; use a class-based definition instead. See https://graphql-ruby.org/schema/class_based_api.html.
-> called from /app/app/models/data_request.rb:3:in <class:DataRequest>' GraphQL::EnumType.define will be removed in GraphQL-Ruby 2.0; use a class-based definition instead. See https://graphql-ruby.org/schema/class_based_api.html. -> called from /app/app/models/data_request.rb:13:in class:DataRequest'
GraphQL::ObjectType.define will be removed in GraphQL-Ruby 2.0; use a class-based definition instead. See https://graphql-ruby.org/schema/class_based_api.html.
-> called from /app/app/models/data_request.rb:26:in <class:DataRequest>' GraphQL::ScalarType.define will be removed in GraphQL-Ruby 2.0; use a class-based definition instead. See https://graphql-ruby.org/schema/class_based_api.html. -> called from /app/app/graphql/types/json_type.rb:3:in '
GraphQL::EnumType.define will be removed in GraphQL-Ruby 2.0; use a class-based definition instead. See https://graphql-ruby.org/schema/class_based_api.html.
-> called from /app/app/graphql/types/action_status_type.rb:1:in <main>'

Resolving console warnings in caesar.

See here
And here

Comment thread Gemfile
Comment thread app/graphql/types/workflow_type.rb
Comment thread app/graphql/types/workflow_type.rb
Comment thread app/graphql/types/workflow_type.rb
Comment thread app/graphql/types/workflow_type.rb
Comment thread app/graphql/types/workflow_type.rb
Comment thread app/graphql/types/workflow_type.rb
Comment thread app/graphql/types/workflow_type.rb
@Tooyosi Tooyosi requested a review from lcjohnso December 16, 2025 20:10
@yuenmichelle1
Copy link
Copy Markdown
Contributor

Looks good as far as I can tell. Testing locally it looks good. I didnt really test any mutation (other than the check to see if they can still be called), but I don't think anyone was really using those.

@Tooyosi Tooyosi merged commit 5bb2f93 into master Jan 2, 2026
3 checks passed
@Tooyosi Tooyosi deleted the migrate-graphql branch January 2, 2026 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants