Open
Conversation
lekhmanrus
commented
Feb 5, 2019
- returned event, not events array
- fixed condition for exact match keys
- removed unused imports
lekhmanrus
commented
Feb 5, 2019
DanielKucal
reviewed
May 12, 2020
| if (!key) { return true; } | ||
| if (exactMatch) { | ||
| if (key.startsWith(Config.prefix)) { | ||
| if (!key.startsWith(Config.prefix)) { |
Contributor
There was a problem hiding this comment.
Why? It doesn't make sens to add Config.prefix to the key below if the key already starts with prefix...
Author
There was a problem hiding this comment.
Tbh, I don't remember exactly why I did that... but I suppose, it is because event.key is a key without prefix, and that fix is to observe key without prefix, so, for example:
Before:
if (exactMatch) {
if (key.startsWith(Config.prefix)) {
// if ('test'.startsWith('im.')) { // false
return event.key === key;
}
return event.key === Config.prefix + key;
// return 'test' === 'im.' + 'test'; // false
}After:
if (exactMatch) {
if (!key.startsWith(Config.prefix)) {
// if (!'test'.startsWith('im.')) { // true
return event.key === key;
// return 'test' === 'test'; // true
}
return event.key === Config.prefix + key;
}But it won't work for key with prefix in both cases - Example 2:
Before:
if (exactMatch) {
if (key.startsWith(Config.prefix)) {
// if ('im.test'.startsWith('im.')) { // true
return event.key === key;
// return 'test' === 'im.test'; // false
}
return event.key === Config.prefix + key;
}After:
if (exactMatch) {
if (!key.startsWith(Config.prefix)) {
// if (!'im.test'.startsWith('im.')) { // false
return event.key === key;
}
return event.key === Config.prefix + key;
// return 'test' === 'im.' + 'im.test'; // false
}But I don't remember exactly. It was a while ago.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.