Fix audio device change events never being called#27
Open
bragma wants to merge 1 commit intozoom:masterfrom
Open
Fix audio device change events never being called#27bragma wants to merge 1 commit intozoom:masterfrom
bragma wants to merge 1 commit intozoom:masterfrom
Conversation
Author
|
Hi, is there a reason why this PR has not been added to latest release? I have to apply it again in my own personal branch... :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add_CB_onComputerMicDeviceChanged(...)
Add_CB_onComputerSpeakerDeviceChanged(...)
Do not work because events are not binded when audio settings context is built. Specified callbacks are never called.
This PR calls BindEvent on GetAudioSettings to correctly hook up SDK events.