Fix #112 (unconditional march=native causes illegal instructions when distributing binaries) by adding control over -march/-mtune compiler flags#122
Closed
petergeneric wants to merge 2 commits intozmwangx:masterfrom
Conversation
…l -march=native -mtune=native with configurable options to prevent crashes when deploying to machines with different CPU capabilities than the build host. Add FFMPEG_MARCH/FFMPEG_MTUNE env vars (highest priority) and build-march-generic feature flag for portable builds. Default behaviour is preserved for backwards compatibility. Fixes zmwangx#112
Author
|
Re-raised as #123 against a feature branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build.rscurrently unconditionally adds-march=native -mtune=nativewhich breaks for CI systems, since the FFmpeg build is tuned for the CI runner's CPU capabilities, which are often more advanced than the target systems.I've added the
build-march-genericfeature flag, and updated the unconditional logic as follows:This would fix #112