Allow customization of which keys caps_word modifies but rebased#3321
Open
Zayon wants to merge 4 commits intozmkfirmware:mainfrom
Open
Allow customization of which keys caps_word modifies but rebased#3321Zayon wants to merge 4 commits intozmkfirmware:mainfrom
Zayon wants to merge 4 commits intozmkfirmware:mainfrom
Conversation
Changed behavior_caps_word.c to be conditionally compiled instead of wrapping the entire contents of the file in an #if. Renamed macros that still referred to "break" instead of "continuation". Changed the type of the continuations count field to allow for more than 255 continuation keys. Reordered a struct to allow for better packing. Switched to statically initializing the devs[] array instead of using an index field in each device's config struct and the init function. Refactored caps_word_keycode_state_changed_listener() and caps_word_enhance_usage() to allow for more easily changing the conditions for what breaks a word and whether mods should be applied in future commits.
Unified devicetree key code parameter decoding between key press and caps word behaviors. Reordered zmk_keycode_state_changed fields for better packing.
Added a shift-list property to caps word to allow adding more keys to be shifted aside from alpha keys. Added a &prog_word behavior, which is the same as &caps_word, except it adds MINUS to shift-list (this matches QMK's caps word behavior). Added a no-default-keys property to caps_word, which removes the implicit alphanumeric keys from continue-list and shift-list so you can fully customize the lists. Also adjusted the default continue keys to include numpad numbers, since those are numbers too.
Author
|
This PR is #1742 but rebased |
Zayon
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR check-list