fix(backlight): Retrieve only brightness from settings when CONFIG_ZMK_BACKLIGHT_ON_START disabled#3304
Open
kurtis-lew wants to merge 1 commit intozmkfirmware:mainfrom
Conversation
Contributor
|
I am pretty sure this applies to underglow as well, and has been a known behavior for some time (so is documented as such). I wouldn't have an objection to changing the behavior, but I'd like to hear opinions from other maintainers. |
…K_BACKLIGHT_ON_START disabled
kurtis-lew
force-pushed
the
fix/backlight-retrieve-brightness-only-from-settings
branch
from
067d1fd to
781358e
Compare
Contributor
|
Given this is established behavior, I'm wary to change this. Especially because this would now ignore the saved value for anyone who received a build with this Kconfig set but used a behavior to turn off the backlight, expecting that to persist until explicitly turned back on. Can you help me understand your use case, so we can maybe come up with a fix that isn't a breaking change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On startup, when the settings subsystem loads the most recent backlight brightness and on-state, it overrides the effect of the
CONFIG_ZMK_BACKLIGHT_ON_STARTKconfig.This PR creates congruency between the settings subsystem and this Kconfig by not calling
zmk_backlight_update()and setting the backlight state tofalsewhenCONFIG_ZMK_BACKLIGHT_ON_START=n.Tested on custom board.