Skip to content

refactor(underglow): Proper settings commit hook, startup/stop fixes#3293

Open
petejohanson wants to merge 1 commit intozmkfirmware:mainfrom
petejohanson:rgb-underglow-better-state-mgmt
Open

refactor(underglow): Proper settings commit hook, startup/stop fixes#3293
petejohanson wants to merge 1 commit intozmkfirmware:mainfrom
petejohanson:rgb-underglow-better-state-mgmt

Conversation

@petejohanson
Copy link
Copy Markdown
Contributor

@petejohanson petejohanson commented Mar 20, 2026

Use a settings handler commit hook to only start RBG if the most recent loaded saved stated has underglow enabled. Additionally, refactor our off code to use a timer stop hook instead of directly submiting the work item to stop the underglow.

PR check-list

  • Branch has a clean commit history
  • Additional tests are included, if changing behaviors/core code that is testable.
  • Proper Copyright + License headers added to applicable files (Generally, we stick to "The ZMK Contributors" for copyrights to help avoid churn when files get edited)
  • Pre-commit used to check formatting of files, commit messages, etc.
  • Includes any necessary documentation changes.

@petejohanson petejohanson self-assigned this Mar 20, 2026
@petejohanson petejohanson requested a review from a team as a code owner March 20, 2026 07:40
Use a settings handler commit hook to only start RBG if the most recent
loaded saved stated has underglow enabled. Additionally, refactor our
off code to use a timer stop hook instead of directly submiting the work
item to stop the underglow.
@petejohanson petejohanson force-pushed the rgb-underglow-better-state-mgmt branch from 938ac4f to 3aacffc Compare March 20, 2026 07:42
@petejohanson petejohanson requested a review from a team as a code owner March 20, 2026 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant