fix(boards) fix missing overlay for mikoto v6.3#3232
fix(boards) fix missing overlay for mikoto v6.3#3232zhiayang wants to merge 2 commits intozmkfirmware:mainfrom
Conversation
petejohanson
left a comment
petejohanson
left a comment
There was a problem hiding this comment.
Just one question on the Kconfig changes. Thanks for the fixes!
| imply RETAINED_MEM | ||
| imply RETENTION | ||
| imply RETENTION_BOOT_MODE |
There was a problem hiding this comment.
I think this is ok as is, and is extra safe not to change things if you build the "bare" mikoto board without the /zmk variant. Did you find these conditionals not working for you? Can you share the exact build command you used when testing this?
There was a problem hiding this comment.
ohhh, interesting. Am I supposed to specify "mikoto/zmk@6.30" now?
Yeah I built locally with just "mikoto@6.3" and it was giving me DTS errors that I traced to smth about retention, so I tried disabling these configs and it worked.
Im not sure if there's a better way? Haven't been keeping up with the zmk progress lately.
There was a problem hiding this comment.
Yes, see the zephyr 4.1 blog post - recent addition. mikoto//zmk@... I believe
There was a problem hiding this comment.
Based on https://docs.zephyrproject.org/latest/hardware/porting/board_porting.html#board-terminology, it should actually be mikoto@6.3//zmk (which I think is a little odd to put the version in the middle)
There was a problem hiding this comment.
The blog post for the 4.1 migration has been updated to reflect those new board IDs with the variant included.
4 participants
PR check-list
Adds a dts for mikoto 6.3, which some people have apparently acquired from somewhere XD
Close #3121
Had to edit some Kconfig things for this to build (was getting dts link errors), not sure if this is necessary or not. Haven't kept up much with ZMK dev.