Improve the estimation for power consumption of the battery#3224
Open
Plecra wants to merge 1 commit intozmkfirmware:mainfrom
Open
Improve the estimation for power consumption of the battery#3224Plecra wants to merge 1 commit intozmkfirmware:mainfrom
Plecra wants to merge 1 commit intozmkfirmware:mainfrom
Conversation
consumption of the battery
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR check-list
Accounting for the effects mentioned in #3223
I've just gone with a simple update to the constants for the underestimated discharge efficiency, the computation is all still accurate.
I've documented the implementation I've used for the battery decay modelling, hopefully clear enough to pass a vibe check :) The changes are quite targeted, I was able to just replace the estimated runtime + battery power consumption.
With the update, the battery's impact on power properly accounts for changes in the configuration of the rest of the board (note the changes in self discharge consumption)!
While the derivation makes sense to me I can't be particularly sure this reflects real world performance, I'd be curious to hear from someone who has tested battery performance in these configurations.