Stop using about, description, address tags#9
Open
fiatjaf wants to merge 2 commits intozmeyer44:mainfrom
Open
Conversation
|
@fiatjaf is attempting to deploy a commit to the Zach's Projects Team on Vercel. A member of the Team first needs to authorize it. |
zmeyer44
reviewed
Jan 10, 2024
Owner
zmeyer44
left a comment
There was a problem hiding this comment.
Changes look good. Just had one small change to remove an extra reference to "description" tag
Co-authored-by: zmeyer44 <54515037+zmeyer44@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's better to just have the same information in a canonical place, saving everybody the hurdle of transmitting the repeated data over and over, and then checking all possible locations.
Since Flockstr is the only client doing these events for now as far as I know, whatever it does will be the actual standard, so if Flockstr checks for "description" data in 3 different places the standard becomes "description can be in any of these places" -- then in the future other apps will each put the description in one of these places, which forces all apps to check all places, but just to be sure apps will opt to publish the data in all of these places forever, which means events will be unnecessarily big forever.
The same applies to "address" and "location".
I am not sure my changes here are fully correct, but I can improve them if you agree with the changes.
Also I recommend following the same approach for other events that Flockstr is generating, the subscription stuff, for example. But I didn't change these since I don't know what is the preferred way. I suggest that you pick one standard and be strict about it. Thank you!