:fix: Fix auto update of max regex length when the current value is m…#241
:fix: Fix auto update of max regex length when the current value is m…#241
Conversation
There was a problem hiding this comment.
Hi! Thanks for working on this. I tested the changes and wanted to share some feedback.
What I'm seeing:
When I test the updated code, the maxLength field doesn't seem to be auto-updating at all anymore. It appears to only accept manual user input and doesn't calculate based on the regex output when patterns change.
Specifically:
- The field keeps the default length value
- Changes to the regex pattern don't trigger any automatic maxLength updates
- Error handling doesn't seem to be displaying as expected
I recorded a quick demo showing the behavior if that would help debug this. It looks like the auto-update functionality might not be triggering in the first place.
Would it be worth investigating why the auto-update isn't working before adding the conditional logic? I'm wondering if there might be something else going on that's preventing the feature from working as intended. Happy to help test further or provide more details!
Screen.Recording.2025-10-02.at.12.46.29.mov
81abc1c to
6a35af4
Compare
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ore than previous one
6a35af4 to
8d8a3f1
Compare
|
@wryonik what is the status of this PR? |
…ore than previous one