Skip to content

:fix: Fix auto update of max regex length when the current value is m…#241

Open
wryonik wants to merge 2 commits intostagingfrom
shubham/reg-564-fe-ux-fix-max-length-auto-calculated-even-after-the-user
Open

:fix: Fix auto update of max regex length when the current value is m…#241
wryonik wants to merge 2 commits intostagingfrom
shubham/reg-564-fe-ux-fix-max-length-auto-calculated-even-after-the-user

Conversation

@wryonik
Copy link
Copy Markdown
Collaborator

@wryonik wryonik commented Sep 26, 2025

…ore than previous one

Copy link
Copy Markdown
Member

@rutefig rutefig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for working on this. I tested the changes and wanted to share some feedback.

What I'm seeing:

When I test the updated code, the maxLength field doesn't seem to be auto-updating at all anymore. It appears to only accept manual user input and doesn't calculate based on the regex output when patterns change.

Specifically:

  • The field keeps the default length value
  • Changes to the regex pattern don't trigger any automatic maxLength updates
  • Error handling doesn't seem to be displaying as expected

I recorded a quick demo showing the behavior if that would help debug this. It looks like the auto-update functionality might not be triggering in the first place.

Would it be worth investigating why the auto-update isn't working before adding the conditional logic? I'm wondering if there might be something else going on that's preventing the feature from working as intended. Happy to help test further or provide more details!

Screen.Recording.2025-10-02.at.12.46.29.mov

@wryonik wryonik force-pushed the shubham/reg-564-fe-ux-fix-max-length-auto-calculated-even-after-the-user branch from 81abc1c to 6a35af4 Compare October 23, 2025 16:26
@zkemailverify zkemailverify temporarily deployed to shubham/reg-564-fe-ux-fix-max-length-auto-calculated-even-after-the-user - registry PR #241 October 23, 2025 16:26 — with Render Destroyed
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Oct 23, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch shubham/reg-564-fe-ux-fix-max-length-auto-calculated-even-after-the-user

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@wryonik wryonik changed the base branch from main to dev October 23, 2025 16:26
@rutefig
Copy link
Copy Markdown
Member

rutefig commented Jan 15, 2026

@wryonik what is the status of this PR?

Base automatically changed from dev to staging April 8, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants