Conversation
la10736
approved these changes
Mar 18, 2026
la10736
left a comment
la10736
left a comment
There was a problem hiding this comment.
LGTM
Great job and good shape. Just some comment that you can ignore.
|
|
||
| /// Errors that can occur when parsing a Nitro attestation document. | ||
| #[derive(Debug)] | ||
| pub enum NitroParseError { |
There was a problem hiding this comment.
Just for the next time. Use thiserror crate could be very useful for error handling in library
There was a problem hiding this comment.
Just a detail, some error cases are not tested ... I guess it's ok because generate them is quite a bit synthetic ...
There was a problem hiding this comment.
That's just a matter of taste. Integration test should just test the main business functionality and (for a library ) that everything the library user need to use it is correctly exported. Nitro parsing and verification errors maybe can be unit.
Anyway, feel free to ignore this statement at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main goal of this PR is to add support for parsing and verifying AWS Nitro attestations.
Given that AWS distributes CRLs in DER format, support for binary CRLs is also added.
For simplicity, we also limit the number of CRLs processed in a single call to 1.
Other than that, mostly cosmetics and refactoring.