Fix protocol mismatch error; implement basic auth for http proxy#19
Open
restyler wants to merge 2 commits intozjael:masterfrom
Open
Fix protocol mismatch error; implement basic auth for http proxy#19restyler wants to merge 2 commits intozjael:masterfrom
restyler wants to merge 2 commits intozjael:masterfrom
Conversation
ipv4 enforcement for socks4; port 80 mitigation for protocol error fixing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under some circumstances the options.port could be '80' string which caused issues with proto mismatch, when the script incorrectly tries to connect to https host via 80 port instead of 443. The line #45 comparison is made less strict to mitigate this.
I also needed basic auth for http proxies. Hopefully this may be useful for someone else. Cheers!