Request to update for Drupal 8.8 #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…www.drupal.org/project/drupal/issues/3055260. Updated webpack version to 4.41.4 in package.json. Changed "module:loaders" to "module:rules" webpack.config.js as this has been changed for later versions of webpack. Added "mode" to be "development" for webpack.config.js. Added package-lock.json to gitignore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Jody! This is requesting an update to the module example associated with https://www.zivtech.com/blog/getting-started-react-drupal-8-and-jsonapi.
Thank you for this example! It helped me a lot with understanding Drupal 8 and React!
However, I did encounter and 403 issue when making the request to toggle the favourite even after setting the cors.config in services.yml.
It ended up being that Drupal core needed the X-CSRF-Token header set with the session token.
I have updated code to retrieve Session token for Drupal 8.8 as per https://www.drupal.org/project/drupal/issues/3055260.
Updated webpack version to 4.41.4 in package.json.
Changed "module:loaders" to "module:rules" webpack.config.js as this has been changed for
later versions of webpack.
Added "mode" to be "development" for webpack.config.js.
Added package-lock.json to gitignore.