chore: cleanup the benchs and Cargo.toml

[Its-Just-Nans]

Fix #605 part 1 and 2

What's the reason to keep generic-array ?

[gemini-code-assist]

Summary of Changes

Hello @Its-Just-Nans, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on dependency cleanup and improving error handling within the project's benchmarks. It removes the generic-array dependency, streamlining the project's dependencies, and refines the getrandom dependency configuration. Additionally, it enhances the robustness of benchmark code by providing more explicit and informative error handling for random number generation failures, contributing to a more maintainable and robust codebase.

Highlights

• Dependency Removal: The generic-array dependency has been completely removed from Cargo.toml and its associated feature, streamlining the project's dependencies.
• Dependency Configuration Refinement: The getrandom dev-dependency configuration was updated to remove an unnecessary empty features = [] specification.
• Improved Error Handling: Error handling for getrandom::fill calls within benchmark files (benches/merge_archive.rs and benches/read_metadata.rs) has been enhanced, replacing unwrap() or generic map_err with more informative error messages.
• Code Cleanup: An unused std::io import was removed from benches/read_metadata.rs.

Ignored Files

• Ignored by pattern: .github/workflows/** (1)
  • .github/workflows/cargo_hack.yml

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[amazon-q-developer]

Summary

This PR performs cleanup work by removing the unused generic-array dependency and improving error handling in benchmark files. The changes look good overall with one minor issue to address.

Key Changes:

• ✅ Removed unused generic-array dependency from Cargo.toml and the aes-crypto feature
• ✅ Improved error handling for getrandom::fill() calls in benchmark files with proper error messages
• ✅ Removed unused io import from benches/read_metadata.rs
• ✅ Added new GitHub workflow for comprehensive feature testing with cargo-hack

Issues Found:

• 🔧 Minor: Incomplete comment in the new workflow file needs completion

The dependency cleanup and error handling improvements are solid changes that enhance code quality. The new cargo-hack workflow will help ensure feature combinations work correctly, which aligns well with the project's guidelines about feature flag testing.

---

You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.

[gemini-code-assist]

Code Review

This pull request cleans up the codebase by removing the generic-array dependency and replacing unwrap() calls in benchmark tests with proper error handling. The changes are well-aligned with the goals outlined in the associated issue. I've included a suggestion to reduce code duplication in the benchmark files for better maintainability.