Open
Conversation
chasingegg
reviewed
Jan 24, 2026
| @@ -0,0 +1,47 @@ | |||
| #pragma once | |||
Collaborator
There was a problem hiding this comment.
why this file's name is 'search_impl..hpp' ??
| if (m == Metric::L2) { | ||
| ret = std::make_unique<IVFSearcher<SQ2QuantizerUniform<Metric::L2>>>(); | ||
| } else if (m == Metric::IP) { | ||
| ret = std::make_unique<IVFSearcher<SQ2QuantizerUniform<Metric::L2>>>(); |
Contributor
Author
There was a problem hiding this comment.
it looks wierd, but it is intentional :)
Collaborator
There was a problem hiding this comment.
why, please add more comments if it is intentional
Contributor
Author
There was a problem hiding this comment.
I don't remember the specific reason but you can see in GraphSearcher it's the same and it works. So I prefer not to modify it
| if (centroids_dim != features) { | ||
| throw std::runtime_error("Centroids dimension mismatch"); | ||
| } | ||
| if (n1 != 1 || n2 != rows) { |
Collaborator
There was a problem hiding this comment.
please check this validation is as expected
Contributor
Author
There was a problem hiding this comment.
it looks good. what's wrong with it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.