Skip to content

Cagra support & update raft version#207

Merged
sre-ci-robot merged 7 commits intozilliztech:mainfrom
presburger:cagra
Nov 24, 2023
Merged

Cagra support & update raft version#207
sre-ci-robot merged 7 commits intozilliztech:mainfrom
presburger:cagra

Conversation

@presburger
Copy link
Copy Markdown

@presburger presburger commented Nov 22, 2023

/kind feature
issue: #10

Update to RAFT 23.12
Update CAGRA integration to improve performance
Avoid post-filtering using RAFT's new filtering feature
Use RAFT's new device_resources_manager to simplify and optimize
resource initialization
Update build infratructure to build for all supported CUDA architectures
Refactor RAFT integration code to more cleanly separate RAFT code from
Knowhere code
Avoid exposing RAFT symbols in any Knowhere header

Signed-off-by: William Hicks <whicks@nvidia.com>
Signed-off-by: William Hicks <whicks@nvidia.com>
Signed-off-by: William Hicks <whicks@nvidia.com>
Signed-off-by: William Hicks <whicks@nvidia.com>
@sre-ci-robot sre-ci-robot requested a review from cydrain November 22, 2023 07:05
@sre-ci-robot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Presburger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify
Copy link
Copy Markdown

mergify bot commented Nov 22, 2023

@presburger 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

Signed-off-by: yusheng.ma <yusheng.ma@zilliz.com>
@presburger
Copy link
Copy Markdown
Author

presburger commented Nov 22, 2023

/kind feature

Signed-off-by: yusheng.ma <yusheng.ma@zilliz.com>
Signed-off-by: yusheng.ma <yusheng.ma@zilliz.com>
@presburger
Copy link
Copy Markdown
Author

/run-e2e

@mergify mergify bot added ci-passed and removed ci-passed labels Nov 23, 2023
@presburger
Copy link
Copy Markdown
Author

/run-e2e

1 similar comment
@presburger
Copy link
Copy Markdown
Author

/run-e2e

@mergify mergify bot added the ci-passed label Nov 23, 2023
@liliu-z
Copy link
Copy Markdown
Collaborator

liliu-z commented Nov 23, 2023

/lgtm

@alexanderguzhva
Copy link
Copy Markdown
Collaborator

/lgtm
given the assumption that a large topk for ivfpq will be tested and added :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants