feat: add locale toggle and Japanese description on heritage detail#294
Merged
zigzagdev merged 3 commits intochore/implement-description_ja-frontendfrom Apr 22, 2026
Conversation
Owner
zigzagdev
commented
Apr 22, 2026
zigzagdev
commented
- Wire locale toggle button in HeritageDetailLayout to update lang query param
- Render heritageNameJp and shortDescriptionJp when locale is ja
- Navigate to results page with search params on sub-header submit
- Update tests for new shortDescriptionJp property
Wire toggleLocale callback from container to layout, render a flag button in the tab bar, and switch HeritageHero between Japanese and English titles based on locale.
Branch on locale in the overview section to show shortDescriptionJp when ja locale is active, falling back to the English shortDescription otherwise. Plumb locale through HeritageDetailLayout and update fixtures accordingly.
Build a URLSearchParams from the current search values and push to /heritages/results when the sub-header form is submitted so submissions from the detail page reach the results view instead of staying in place.
zigzagdev
force-pushed
the
feat/add-new-property-container_viewcomponent
branch
from
6ac561e to
6695fec
Compare
zigzagdev
merged commit 312fdd5
into
chore/implement-description_ja-frontend
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.