fix: activate contributed commands explicitly#40
Open
RasputinKaiser wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Adds explicit VS Code activation events for each contributed Storm Search command.
Why
Closes #39. The reported warning says
command 'custom-search.searchInFolder' not foundafter pressing the contributed keybinding on a fresh install. The command is contributed inpackage.jsonand registered insrc/extension.ts, but the extension manifest currently has an emptyactivationEventsarray. ExplicitonCommandactivation events make VS Code activate the extension before running the contributed commands.Changes
onCommand:custom-search.openSearch.onCommand:custom-search.openNewSearchTab.onCommand:custom-search.searchInFolder.Duplicate check
gh pr list --repo zigcBenx/storm-search --state all --search "39 Command not found"returned no PRs.gh pr list --repo zigcBenx/storm-search --state all --search "command not found activationEvents searchInFolder"returned no PRs.Testing
npm run lintis currently blocked by the repository not having an ESLint configuration file, so ESLint exits before linting source files. I did not add unrelated lint configuration in this PR.