Register queue on streaming handle before sending the subscribe request #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #77 +/- ##
==========================================
- Coverage 90.29% 90.25% -0.04%
==========================================
Files 25 25
Lines 2122 2124 +2
Branches 91 92 +1
==========================================
+ Hits 1916 1917 +1
- Misses 199 200 +1
Partials 7 7 ☔ View full report in Codecov by Sentry. |
This commit creates the subscription queue befor sending out the subscribe request. This ensures that if the data server sends an update event before the subscribe request returns, the data is still processed.
tobiasah
force-pushed
the
tobiasa/fix_subscribe_fast_update
branch
from
305b7a5 to
94cc4f7
Compare
zi-2k
approved these changes
Dec 9, 2024
markheik
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit creates the subscription queue befor sending out the subscribe request. This ensures that if the data server sends an update event before the subscribe request returns, the data is still processed.