Allow garcefull subscripiton cancellation #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markheik
approved these changes
Nov 19, 2024
markheik
reviewed
Nov 19, 2024
tobiasah
force-pushed
the
tobiasa/l1-2546
branch
from
e94e5bd to
44aa085
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #75 +/- ##
==========================================
+ Coverage 89.96% 90.29% +0.32%
==========================================
Files 25 25
Lines 2113 2122 +9
Branches 91 91
==========================================
+ Hits 1901 1916 +15
+ Misses 204 199 -5
+ Partials 8 7 -1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
markheik
reviewed
Nov 19, 2024
markheik
approved these changes
Nov 19, 2024
Collaborator
markheik
left a comment
markheik
left a comment
There was a problem hiding this comment.
LGTM. Left one comment
tobiasah
force-pushed
the
tobiasa/l1-2546
branch
2 times, most recently
from
aa959ff to
871345e
Compare
This commit prevents an error is propagated to the data server if a subcription is disconnected intentionnally without an error.
tobiasah
force-pushed
the
tobiasa/l1-2546
branch
from
871345e to
2756340
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit prevents an error is propagated to the data server if a subcription is disconnected intentionnally without an error.