fix problem of streaming errors causing a unsubscribe #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #74 +/- ##
==========================================
+ Coverage 90.03% 90.12% +0.09%
==========================================
Files 25 25
Lines 2097 2097
Branches 91 91
==========================================
+ Hits 1888 1890 +2
+ Misses 201 199 -2
Partials 8 8 ☔ View full report in Codecov by Sentry. |
tobiasah
force-pushed
the
tobiasa/l1-2544
branch
from
d72ec43 to
fe2490d
Compare
This commit fixes a bug which caused a subscription to unsubscribe when a streaming error was received since a uninitialized value was accessed. In addition errors happening in the subscription handling are now bubbled up to the dataserver to show up in the logs.
tobiasah
force-pushed
the
tobiasa/l1-2544
branch
from
fe2490d to
bf255a7
Compare
fabiorossetto
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug which caused a subscription to unsubscribe when a streaming error was received since a uninitialized value was accessed. In addition errors happening in the subscription handling are now bubbled up to the dataserver to show up in the logs.