Remove ALURE dependency and add built-in WAV loader for macOS compatibility#139
Open
krank56 wants to merge 2 commits intozevv:masterfrom
Open
Remove ALURE dependency and add built-in WAV loader for macOS compatibility#139krank56 wants to merge 2 commits intozevv:masterfrom
krank56 wants to merge 2 commits intozevv:masterfrom
Conversation
…RE functionality. Update Makefile to remove ALURE dependencies and adjust compiler flags.
krank56
changed the title
Owner
|
Thanks for the PR. I'm not sure I'm comfortable to drop the default wav loader for the other platforms; your implementation might work with the default shipped WAV files for now, but does it properly handle any WAV you throw at it? I don't do any apple stuff myself so I have no way to try, but I'm pretty sure it should be possible to pull in and build your own alure somehow? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since brew has removed the alure formula, I used alc instead for mac build