Use configured stream name for JetStream consumer#99
Open
me2seeks wants to merge 1 commit intozeromicro:masterfrom
Open
Use configured stream name for JetStream consumer#99me2seeks wants to merge 1 commit intozeromicro:masterfrom
me2seeks wants to merge 1 commit intozeromicro:masterfrom
Conversation
Greptile found no issues!From now on, if a review finishes and we haven't found any issues, we will not post anything, but you can confirm that we reviewed your changes in the status check section. This feature can be toggled off in your Code Review Settings by deselecting "Create a status check for each PR". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Summary
queue.StreamNamevalue insteadImportant Files Changed
natsq/consumer.goConfidence score: 5/5
Sequence Diagram
sequenceDiagram participant User participant ConsumerManager participant NATS participant JetStream participant Consumer User->>ConsumerManager: "MustNewConsumerManager(cfg, queues, mode)" ConsumerManager->>NATS: "Connect(serverUri, options)" NATS-->>ConsumerManager: "connection" ConsumerManager->>ConsumerManager: "registerQueue(queue)" User->>ConsumerManager: "Start()" ConsumerManager->>ConsumerManager: "subscribe(queue)" alt NatJetMode ConsumerManager->>JetStream: "New(conn)" JetStream-->>ConsumerManager: "jetstream instance" ConsumerManager->>JetStream: "Stream(ctx, queue.StreamName)" JetStream-->>ConsumerManager: "stream" ConsumerManager->>JetStream: "CreateOrUpdateConsumer(ctx, config)" JetStream-->>ConsumerManager: "consumer" ConsumerManager->>JetStream: "Consume(handleFunc, options)" JetStream->>Consumer: "HandleMessage(msg)" Consumer-->>JetStream: "result" JetStream->>JetStream: "Ack()" else NatDefaultMode ConsumerManager->>NATS: "QueueSubscribe(subject, queueName, handleFunc)" NATS->>Consumer: "HandleMessage(msg)" Consumer-->>NATS: "result" NATS->>NATS: "Ack()" end User->>ConsumerManager: "Stop()" ConsumerManager->>NATS: "Close()"