fix: NewJetProducer ctx is nil causing crash#88
Open
4566704 wants to merge 1 commit intozeromicro:masterfrom
Open
fix: NewJetProducer ctx is nil causing crash#884566704 wants to merge 1 commit intozeromicro:masterfrom
4566704 wants to merge 1 commit intozeromicro:masterfrom
Conversation
There was a problem hiding this comment.
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
|
|
||
| // JetMode | ||
| j, _ := natsq.NewJetProducer(&c) | ||
| j, _ := natsq.NewJetProducer(&c, context.Background()) |
There was a problem hiding this comment.
logic: Error handling is ignored. Could lead to nil pointer dereference if producer creation fails.
Suggested change
| j, _ := natsq.NewJetProducer(&c, context.Background()) | |
| j, err := natsq.NewJetProducer(&c, context.Background()) | |
| if err != nil { | |
| log.Fatalf("Error creating jet producer: %v", err) | |
| } |
There was a problem hiding this comment.
LGTM
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Author
|
BUG说明: 修复说明: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NewJetProducer 创建 JetProducer struct时没有赋值 ctx,因为JetProducer的一些方法要用到ctx,ctx为nil引发panic:
Greptile Summary
Fixed a critical nil context issue in the NATS JetStream producer implementation that was causing panics during stream operations.
natsq/producer.go:NewJetProducer()constructor and properly initialized it in the JetProducer structexample/natsq/publisher/publisher.goto passcontext.Background()to NewJetProducer callsexample/natsq/publisher/publisher.goshould be improved for CreateOrUpdateStream operations💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!