Add NATS JetStream OTel propagation support#100
Open
me2seeks wants to merge 2 commits intozeromicro:masterfrom
Open
Add NATS JetStream OTel propagation support#100me2seeks wants to merge 2 commits intozeromicro:masterfrom
me2seeks wants to merge 2 commits intozeromicro:masterfrom
Conversation
Introduce trace header carrier plus publish/consume helpers with context extraction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Summary
Adds OpenTelemetry trace propagation support for NATS JetStream, enabling distributed tracing across NATS message boundaries.
HeaderCarrierto bridge NATS headers with OTel'sTextMapCarrierinterfacePublishMsgandPublishWithHeadersmethodsConsumeHandlerinterface signature to acceptcontext.Context(breaking change for existing implementations)kq) for consistencyConfidence Score: 5/5
Important Files Changed
Sequence Diagram
sequenceDiagram participant Publisher participant OTel as OTel Propagator participant HeaderCarrier participant NATS participant Consumer participant Handler as ConsumeHandler Publisher->>HeaderCarrier: NewHeaderCarrier(&msg.Header) Publisher->>OTel: Inject(ctx, carrier) OTel->>HeaderCarrier: Set(key, value) HeaderCarrier->>NATS: msg.Header updated Publisher->>NATS: PublishMsg(ctx, msg) NATS->>Consumer: Message delivered Consumer->>HeaderCarrier: NewHeaderCarrier(&headers) Consumer->>OTel: Extract(ctx, carrier) OTel->>HeaderCarrier: Get(key) HeaderCarrier-->>OTel: trace context values OTel-->>Consumer: ctx with trace Consumer->>Consumer: contextx.ValueOnlyFrom(ctx) Consumer->>Handler: Consume(ctx, msg)