updates to whitepaper, readme.md and directory structure#25
Merged
iamdefinitelyahuman merged 52 commits intozerolawtech:masterfrom Nov 24, 2019
Merged
updates to whitepaper, readme.md and directory structure#25iamdefinitelyahuman merged 52 commits intozerolawtech:masterfrom
iamdefinitelyahuman merged 52 commits intozerolawtech:masterfrom
Conversation
…f money transmission issues
…f money transmission issues
…aper to "papers & research"
Collaborator
|
Good stuff @lex-node! A couple things that jump out at me immediately:
I'll delve into the whitepaper shortly. |
Collaborator
iamdefinitelyahuman
left a comment
There was a problem hiding this comment.
It's a thing of beauty :) Thank you for putting so much work into this! Some general comments:
- The mix of markdown and HTML kinda hurts my brain, but we discussed moving away from markdown so I didn't flag anything related to that
- We need to address #21 as a part of this PR, so we can rename everything once and for all and then finalize all the links
- I'm not a huge fan of the full function selectors including inputs, I think if you aren't later discussing the usage of specific variables we could reduce them to just
ContractName.functionName
Overall really good content here! Very excited to roll this out.
…into legal-updates
Collaborator
Author
these are now done
these are now done |
Co-Authored-By: Ben Hauser <35276322+iamdefinitelyahuman@users.noreply.github.com>
…into legal-updates
Collaborator
|
Per the comments, I will write a section on the rationale behind our module system as opposed to using a proxy pattern. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.