Skip to content

fix: serve default bind address 127.0.0.1 → 0.0.0.0 #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chaosreload wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: serve default bind address 127.0.0.1 → 0.0.0.0 #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ fn main() -> Result<()> {
eprintln!(
" test-exec <workdir> <command> - Test executing a command in a fork"
);
eprintln!(" serve <workdir> [port] - Start API server");
eprintln!(" serve <workdir> [port] [--bind addr] - Start API server (default bind: 0.0.0.0)");
Ok(())
}
}
Expand Down Expand Up @@ -390,10 +390,27 @@ fn load_api_keys() -> Vec<String> {

fn cmd_serve(args: &[String]) -> Result<()> {
if args.len() < 1 {
bail!("Usage: zeroboot serve <workdir>[,lang:workdir2,...] [port]");
bail!("Usage: zeroboot serve <workdir>[,lang:workdir2,...] [port] [--bind <addr>]");
}
let port: u16 = args.get(1).and_then(|p| p.parse().ok()).unwrap_or(8080);

// Parse optional --bind flag (default 0.0.0.0 for container/K8s compatibility).
// K8s health probes connect from the Pod IP (not localhost), and Service ClusterIP
// routing requires the server to listen on all interfaces.
// For local dev, use: --bind 127.0.0.1
let bind_addr = {
let mut addr = "0.0.0.0".to_string();
let mut i = 2;
while i + 1 < args.len() {
if args[i] == "--bind" {
addr = args[i + 1].clone();
break;
}
i += 1;
}
addr
};

// Parse workdir specs: "workdir" or "python:workdir1,node:workdir2"
let mut templates = std::collections::HashMap::new();
for spec in args[0].split(',') {
Expand Down Expand Up @@ -430,10 +447,10 @@ fn cmd_serve(args: &[String]) -> Result<()> {
.route("/v1/metrics", axum::routing::get(metrics_handler))
.with_state(state);

let listener = tokio::net::TcpListener::bind(format!("127.0.0.1:{}", port))
let listener = tokio::net::TcpListener::bind(format!("{}:{}", bind_addr, port))
.await
.unwrap();
eprintln!("Zeroboot API server listening on port {}", port);
eprintln!("Zeroboot API server listening on {}:{}", bind_addr, port);
axum::serve(
listener,
app.into_make_service_with_connect_info::<std::net::SocketAddr>(),
Expand Down