-
Notifications
You must be signed in to change notification settings - Fork 8.4k
dts: stepper: move m0/m1-gpios property in stepper-controller #100617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
m0-gpios and m1-gpios are common in step-dir stepper drivers and hence placing them in common stepper-controller.yaml along with step-gpios and dir-gpios Signed-off-by: Jilay Pandya <jilay.pandya@outlook.com>
|
|
This solution does not seem extensible. Drivers like A4988, DRV8825 support 3 pins for setting micro-stepping which would not work (or, say extend), in this case. A possible solution, would be to revert to the phandle logic for the microstepping pins, like earlier: & use the existing to determine the microstepping resolution in the case of hardwired pins. Also, we can then enforce this exclusivity in the driver level (eiither set via gpio's or hardwired(static)). |
|
One could hardwire one pin, while still toggling the others via gpio. In this scenario, the idx of the pin getting toggled via gpio is important to know.The available micro-step resolutions would be reduced, but the application would still have the possibility to select. We can extend the list as soon as one of the aforementioned drivers gets upstreamed. |
|
Hardwiring only 1 microstep pin but leaving the others feels like a serious edge case. At that point having the user set the microstep resolution manually would be something I am fine with. In addition, drv84xx and tmc22xx are currently all or nothing in regards to microstep pins while the allegro currently requires the microstep pins (that should be fixed at some point). |
Ok, but this does seem contra-intuitive to me, since phandles provide the flexibility of any large number of gpios to be inserted. |



m0-gpios and m1-gpios are common in step-dir stepper drivers and hence placing them in common stepper-controller.yaml along with step-gpios and dir-gpios