Skip to content

Equipmenttreebuilderleaves#188

Closed
chestm007 wants to merge 1 commit intomainfrom
equipmenttreebuilderleaves
Closed

Equipmenttreebuilderleaves#188
chestm007 wants to merge 1 commit intomainfrom
equipmenttreebuilderleaves

Conversation

@chestm007
Copy link
Copy Markdown
Contributor

Description

minor changes, QOL and performance

Test Steps

Tested across a large network, and it does the needful. test locally i guess?

Checklist

If any of these are not applicable, strikethrough the line ~like this~. Do not delete it!. Let the reviewer decide if you should have done it.

Code

  • [ x ] I have performed a self review of my own code (including checking issues raised when creating the PR).
  • [ x ] I have added/updated unit tests for these changes, and if not I have explained why they are not necessary.
  • [ x ] I have commented my code in any hard-to-understand or hacky areas.
  • [ x ] I have handled all new warnings generated by the compiler or IDE.
  • [ x ] I have rebased onto the target branch (usually main).

Documentation

  • [ x ] I have updated the changelog.
  • I have updated any documentation required for these changes.

Breaking Changes

  • [ x ] I have considered if this is a breaking change and will communicate it with other team members by posting it on the Slack breaking-changes channel.

Please leave a summary of the breaking changes here and then post it on the Slack breaking-changes channel to notify the team about it.

@chestm007 chestm007 requested review from charlta and kgreav July 11, 2025 13:45
@kgreav
Copy link
Copy Markdown
Member

kgreav commented Jul 12, 2025

BTW you'll also have to rebase on anthonys changes, and i'll probably backport this to 0.49.0 as well.. maybe

@chestm007 chestm007 force-pushed the equipmenttreebuilderleaves branch from 2ec363a to 50b0265 Compare July 23, 2025 07:56
Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>
@chestm007 chestm007 force-pushed the equipmenttreebuilderleaves branch from 50b0265 to 2db8e92 Compare July 29, 2025 04:44
Copy link
Copy Markdown
Member

@kgreav kgreav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually - add a changelog entry plz

@chestm007
Copy link
Copy Markdown
Contributor Author

changing PR branch to DEV-3524

@chestm007 chestm007 closed this Aug 4, 2025
@chestm007 chestm007 deleted the equipmenttreebuilderleaves branch August 20, 2025 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants