Closed
Conversation
kgreav
requested changes
Jul 12, 2025
src/zepben/evolve/services/network/tracing/networktrace/actions/equipment_tree_builder.py
Outdated
Show resolved
Hide resolved
src/zepben/evolve/services/network/tracing/networktrace/actions/equipment_tree_builder.py
Outdated
Show resolved
Hide resolved
test/services/network/tracing/networktrace/actions/test_equipment_tree_builder.py
Show resolved
Hide resolved
Member
|
BTW you'll also have to rebase on anthonys changes, and i'll probably backport this to 0.49.0 as well.. maybe |
2ec363a to
50b0265
Compare
Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>
50b0265 to
2db8e92
Compare
chestm007
commented
Jul 31, 2025
src/zepben/ewb/services/network/tracing/networktrace/actions/equipment_tree_builder.py
Show resolved
Hide resolved
chestm007
commented
Jul 31, 2025
test/services/network/tracing/networktrace/actions/test_equipment_tree_builder.py
Show resolved
Hide resolved
kgreav
approved these changes
Aug 1, 2025
src/zepben/ewb/services/network/tracing/networktrace/actions/equipment_tree_builder.py
Show resolved
Hide resolved
test/services/network/tracing/networktrace/actions/test_equipment_tree_builder.py
Show resolved
Hide resolved
kgreav
requested changes
Aug 1, 2025
Member
kgreav
left a comment
There was a problem hiding this comment.
actually - add a changelog entry plz
Contributor
Author
|
changing PR branch to DEV-3524 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
minor changes, QOL and performance
Test Steps
Tested across a large network, and it does the needful. test locally i guess?
Checklist
If any of these are not applicable, strikethrough the line
~like this~. Do not delete it!. Let the reviewer decide if you should have done it.Code
Documentation
Breaking Changes
Please leave a summary of the breaking changes here and then post it on the Slack breaking-changes channel to notify the team about it.