Skip to content

[EWB-1562] Added missing default network state operators (NORMAL) if you are calling SetDirection.run directly, and added missing core trace tests.#187

Merged
charlta merged 1 commit intomainfrom
EWB-1562-port-core-trace-test
Jul 4, 2025
Merged

[EWB-1562] Added missing default network state operators (NORMAL) if you are calling SetDirection.run directly, and added missing core trace tests.#187
charlta merged 1 commit intomainfrom
EWB-1562-port-core-trace-test

Conversation

@charlta
Copy link
Copy Markdown
Member

@charlta charlta commented Jul 4, 2025

Description

Ported the missing core trace tests from the JVM implementation.

While porting the tests, found there was a missing default network state operators (NORMAL) if you are calling SetDirection.run directly, so added that.

Associated tasks

  • None.

Test Steps

As shown in the new test, you can now run

await Tracing.set_direction().run(n)

instead of the old

await Tracing.set_direction().run(n, NetworkStateOperators.NORMAL)

Checklist

If any of these are not applicable, strikethrough the line ~like this~. Do not delete it!. Let the reviewer decide if you should have done it.

Code

  • I have performed a self review of my own code (including checking issues raised when creating the PR).
  • I have added/updated unit tests for these changes, and if not I have explained why they are not necessary.
  • I have commented my code in any hard-to-understand or hacky areas.
  • I have handled all new warnings generated by the compiler or IDE.
  • I have rebased onto the target branch (usually main).

Documentation

  • I have updated the changelog.
    - [ ] I have updated any documentation required for these changes.

Breaking Changes

  • I have considered if this is a breaking change and will communicate it with other team members by posting it on the Slack breaking-changes channel.

Non-breaking.

…ling `SetDirection.run` directly, and added missing core trace tests.

Signed-off-by: Anthony Charlton <anthony.charlton@zepben.com>
@ryanjcoleman
Copy link
Copy Markdown
Member

Task linked: EWB-1562 Port CoreTraceTest to Python SDK

@charlta charlta marked this pull request as ready for review July 4, 2025 02:05
@charlta charlta requested review from a team and chestm007 July 4, 2025 02:05
@charlta charlta merged commit 319bafa into main Jul 4, 2025
3 checks passed
@charlta charlta deleted the EWB-1562-port-core-trace-test branch July 4, 2025 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants