Debug logging#183

Closed

chestm007 wants to merge 39 commits intomainfrom

Contributor

chestm007 commented May 29, 2025

Description

A summary of the changes and what they achieve. If there is a ClickUp task with decent detail associated with this change the summary can be brief, otherwise please add some motivation and context here.

If you have added new dependencies to the project please state why.

Associated tasks

List any other tasks / PRs that are required to be merged alongside this one (e.g. front end task for back end change or vice versa). If a PR exists, add a link. If not, just add an appropriate note here so reviewers know there is a dependency and will hold off merging until all things are ready.

Test Steps

Explain in detail how your reviewer can test the changes proposed in this PR. If it cannot be tested, leave an explanation on why.

Checklist

If any of these are not applicable, strikethrough the line ~like this~. Do not delete it!. Let the reviewer decide if you should have done it.

Code

[ X ] I have performed a self review of my own code (including checking issues raised when creating the PR).
[ X ] I have added/updated unit tests for these changes, and if not I have explained why they are not necessary.
[ X ] I have commented my code in any hard-to-understand or hacky areas.
[ X ] I have handled all new warnings generated by the compiler or IDE.
[ X ] I have rebased onto the target branch (usually main).

Documentation

[ X ] I have updated the changelog.
I have updated any documentation required for these changes.

Breaking Changes

[ X ] I have considered if this is a breaking change and will communicate it with other team members by posting it on the Slack breaking-changes channel.

Please leave a summary of the breaking changes here and then post it on the Slack breaking-changes channel to notify the team about it.

chestm007 added 30 commits

May 27, 2025 22:49

43457ba

Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>


          more tests, slight optimisation

e007fb4

Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>


          Add step path provider, and some tests

dc7870a

also polished off a few other bits and pieces

Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>


          be helpful if the TestNetworkBuilder knew what a Busbar was

7c4b033

Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>


          stashing changes

3b69b62

Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>


          NetworkTraceStepPathProvider seems to do the needful

9b9ce0d

Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>


          Network Trace now supports cuts and clamps

3777cde

Busbranch trace broke, theres more fixes to pull in yet.
Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>


          Reworking some internal classes to be less boilerplate

5a6f2d8

Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>


          this class isnt a test...

847539e

Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>


          Reworked NetworkStateOperators so auto complete works

a972967

We're also not creating any instances of the objects anymore.
Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>


          I broke some type hinting, and created circular imports. #winning

44e083d

Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>


          Pretty bulky change

cf24250

- Complete rework of TraversalQueue, and its related counterparts
- Got the last of the changes in from DEV-2506 in the kotlin sdk

Broken stuff:
- WeightedPriorityQueue has a hack in it to make it "kinda work" for now, that class needs some love.
Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>


          Reworked the internals of network_trace.Conditions

a410f72

Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>

0a3a303

Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>


          get rid of alot of if isinstance in favor of singledispatch

e31b95e

Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>


          Fixed WeightedPriorityQueue, and rework of network trace/traversal

9589cd3

Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>


          More typing, and refactoring code to be more pythonic

fb08464

Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>


          slight refactoring to clean up API

81d7f7f

Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>


          Chasing an exponential queueing issue

06c7d4e

NetworkTrace keeps queueing every terminal from a junction as though the initial trace direction is wrong.
Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>


          yield != return.

6c54dbf

Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>


          codebase inline with ewb-sdk-jvm PR#220

8b4f434

Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>


          DEV-2568 PR#220, tracing fixes, and more unit tests - 2 unexpected te…

519c0b9

…st failures

Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>


          because ofcourse i accidentally wrote tests that modify global state

c80c9be

Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>


          pointless code prettifying

66d0449

Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>


          comparing a bound method to an enum will always return False silently

4947e4b

Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>


          [DEV-2573] changes ported from Kotlin SDK (#221)

d4d9d17

Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>


          Busbranch tests fixed, this needs verification that its not dumb

84453a9

Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>


          phase inferring is solved 💪

2510f21

Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>


          Added action blocks for TestNetworkBuilder.with_clamp and `TestNetw…

3c17140

…orkBuilder.with_cut`

Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>


          [DEV-2592] - added tests from kotlin sdk

bfd7add

python SDK didnt have the same bug, tests added to make sure it never does
Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>

chestm007 added 9 commits

May 27, 2025 22:49


          [DEV-2766] NetworkTrace/Traversal now correctly respects `can_sto…

abff444

…p_on_start` when providing multiple start items.

Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>


          rebase off main incase new build system takes a while

242c10b

Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>


          remove version lock for pytest-subtests, it can sort itself out

5ebd932

Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>


          DEV-2382

5c543ae

Fixed some stuff that was broken in assign to [Lv]Feeders as ported over missing tests
Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>


          should update the changelog.

9dbfb65

Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>


          log inferred phases properly.

e7781b3

Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>


          Add debug logging to Traversal and traces and exposed them via all …

3946da0

…`Tracing` methods and `TestNetworkBuilder.build`.

Just need to write the tests for the actual wrapper
Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>


          reworked the logger slightly, added heaps of docs to it

7ff79e4

Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>


          Minor formatting fix

f532d80

Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>

Contributor Author

chestm007 commented May 29, 2025

ugh, wrong branch

chestm007 closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet