Conversation
Set BusbarSection.max_terminals = 1 Tests not updated, 3 fails expected
…ry to ../traversal and fixed all references pointing too it untested change
… it, but it reads very familiar to the kotlin code.
…in here, but ill wait a bit incase the answers are obvious later - marked with TODO: items left in here: - finish off traversal.py - weighted_priority_queue.py
items left in here: - weighted_priority_queue.py (check if needed - phases - networktrace - feeder? - connectivity? - wait for everything to explode and deal with it then
actions directory done items left in here: - weighted_priority_queue.py (check if needed - phases - feeder - connectivity - conditions - wait for everything to explode and deal with it then THE LIST IS GETTING SMALLER THOUGH
Update some imports, now to decipher feeders. items left in here: - weighted_priority_queue.py (check if needed - phases - feeder - connectivity - conditions - wait for everything to explode and deal with it then THE LIST IS GETTING SMALLER THOUGH
…ommitting where im up too
theres a few changes missing, this seems to be the easiest way to track them nowm
…nt where i need some guidance on what magic these interfaces are doing :(
I'm in a groove now 👍
TODO: implement the rest of the constructors
175 tests pass now
IT breaks type hinting for the param :/ it works, but its unclear.
beginings of implementing `conditions` now that ive got a good handle on the internal logic of these functions, the cause of whole bunch of the remaining fails
Implemented bitwise phase tracking, interested to see difference in memory usage vs previous
To fix: - Bus branch - Phase Inferrer (doing too much, and spitting out the wrong phase in 1 occurance | 5 fails total) - TestNetworkDatabaseReader: i think this is working, just need to update the expected calls #micdrop
7 fails left, 2 tests are actually broken, the other 5 work, but get the wrong output
Unused imports, duplicate methods, formatting, etc, etc
Member
|
Task linked: EWB-3084 Update Python SDK |
chestm007
force-pushed
the
EWB-3084-Update-Python-SDK
branch
from
7d38003 to
77c8a08
Compare
chestm007
force-pushed
the
EWB-3084-Update-Python-SDK
branch
2 times, most recently
from
b168cca to
3a43227
Compare
Signed-off-by: Kurt Greaves <kurt.greaves@zepben.com>
Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>
Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>
Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>
chestm007
force-pushed
the
EWB-3084-Update-Python-SDK
branch
from
81894d3 to
ed8da23
Compare
Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>
kgreav
approved these changes
May 16, 2025
kgreav
approved these changes
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Complete rewrite of the tracing API to match ewb-sdk-jvm. The new
NetworkTracenow powers all tracing thingsAssociated tasks
There are still a handful of tests missing here, and some tidying up work to be done
queue_conditions/stop_conditions. surely theres a way to magic them in thereTest Steps
TODO: Explain in detail how your reviewer can test the changes proposed in this PR. If it cannot be tested, leave an explanation on why.
Checklist
If any of these are not applicable, strikethrough the line
~like this~. Do not delete it!. Let the reviewer decide if you should have done it.Code
Documentation
Breaking Changes
Please leave a summary of the breaking changes here and then post it on the Slack breaking-changes channel to notify the team about it.