Fix: disconnect correct client instance in zod test finally block#2415
Merged
Fix: disconnect correct client instance in zod test finally block#2415
finally block#2415Conversation
Co-authored-by: ymc9 <104139426+ymc9@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback from review on merging dev to main
Fix: disconnect correct client instance in zod test Feb 27, 2026
finally block
ymc9
approved these changes
Feb 27, 2026
ymc9
approved these changes
Feb 27, 2026
ymc9
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the
can be constructed directly from clienttest, theconst clientdeclared inside thetryblock is not accessible infinallydue to JS block scoping — soclient.$disconnect()infinallywas silently closing the outerbeforeEachclient instead, leaving the locally created client open.Change
localClientand hoist it above thetryblock sofinallycloses the correct instance🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.