fix: use Readable.from(buffer) for Google Drive upload#3
Open
samsulrifai wants to merge 1 commit into
Open
Conversation
The original code passed busboy's file stream directly to googleapis drive.files.create(), which caused 'part.body.pipe is not a function' error due to busboy v2 breaking changes. Now we buffer the stream data first, then create a fresh Readable stream via Readable.from(fileBuffer) for the upload.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Upload to Google Drive fails with
part.body.pipe is not a functionerror.This is caused by busboy v2 breaking changes where
file(part) no longer exposes a standard Node.js readable stream directly as.body.Solution
Buffer the incoming stream data first, then create a fresh
Readablestream viaReadable.from(fileBuffer)for the Google Drive upload API call.Changes
import { Readable } from 'stream'Readable.from(fileBuffer)todrive.files.create()instead of the raw busboy streamTesting