feat: add preference to enable compact mode on browser fullscreen#9883
Closed
marciosobel wants to merge 0 commit intozen-browser:devfrom
Closed
feat: add preference to enable compact mode on browser fullscreen#9883marciosobel wants to merge 0 commit intozen-browser:devfrom
marciosobel wants to merge 0 commit intozen-browser:devfrom
Conversation
dosubot
Bot
added
size:M
Author
|
Also, I thought about creating a "Compact mode" section on the preferences page, but after seeing the comment at #6243 (comment), I opted to leave it to the advanced preferences page. Lmk if this should have it's own section! |
mr-cheffy
requested changes
Aug 14, 2025
Member
mr-cheffy
left a comment
mr-cheffy
left a comment
There was a problem hiding this comment.
Looks good! Some things:
- I think this is important enough to have it's own checkbox on the settings page.
- Could it be possible if a simple test is written for this specifically?
Thanks!
| Services.prefs.addObserver('zen.tabs.vertical.right-side', tabIsRightObserver); | ||
|
|
||
| const enableOnFullscreenObserver = this._updateEnableOnFullscreen.bind(this); | ||
| Services.prefs.addObserver('zen.view.compact.enable-on-fullscreen', enableOnFullscreenObserver); |
Member
There was a problem hiding this comment.
I think we should use XPCOMUtils.defineLazyPreferenceGetter here instead of adding our own observers.
|
This would close #614 in the best possible way. I now have to follow up F11 keypress with Ctrl+Alt+C, which is frustrating. |
dosubot
Bot
added
size:XS
mr-cheffy
temporarily deployed
to
Deploy-Twilight
GitHub Actions
Inactive
Author
|
I wanted to come back to this PR, but I am unable to build the browser again (I run out of RAM every time, even if it's running in one thread). Maybe some other time! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new preference
zen.view.compact.enable-on-fullscreen, which enables compact mode whenever the browser window goes on fullscreen (e.g. when pressing F11).This is for situations I commonly find myself into, like when I have more than one window on my screen or when I'd like to use the split tabs feature (sometimes even both!), the non-compact mode takes up too much space.
2025-08-14.11-08-49.online-video-cutter.com.mp4