feat: add preference to toggle URL bar autofocus on startup#8990
Closed
Ernestas-t wants to merge 2 commits intozen-browser:devfrom
Closed
feat: add preference to toggle URL bar autofocus on startup#8990Ernestas-t wants to merge 2 commits intozen-browser:devfrom
Ernestas-t wants to merge 2 commits intozen-browser:devfrom
Conversation
Add zen.startup.focus-urlbar preference to control whether the URL bar is automatically focused when switching tabs during startup. Defaults to true to maintain current behavior while allowing users to disable this feature if desired.
mr-cheffy
requested changes
Jun 12, 2025
| if ( | ||
| gBrowser.selectedTab !== this._emptyTab && | ||
| selectURLBar && | ||
| Services.prefs.getBoolPref('zen.startup.focus-urlbar', true) |
Member
There was a problem hiding this comment.
This isnt the correct call as it woudnt just be on startup. Rather dont call openTab on selectStartpage
Member
|
@Ernestas-t not sure if you still want to implement this, but there are some git conflicts. I'll close this and please do re-open with the conflicts solved if you are interested ^^ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add zen.startup.focus-urlbar preference to control whether the URL bar is automatically focused when switching tabs during startup. Defaults to true to maintain current behavior while allowing users to disable this feature if desired.
It would also be good to have a toggle in the UI settings, but i think it's best to leave it for a separate commit.