gh-13653: fix copy url button/shortcut to respect decodeURLsOnCopy spec#13659
Open
ashvwinn wants to merge 7 commits into
Open
gh-13653: fix copy url button/shortcut to respect decodeURLsOnCopy spec#13659ashvwinn wants to merge 7 commits into
decodeURLsOnCopy spec#13659ashvwinn wants to merge 7 commits into
Conversation
dosubot
Bot
added
the
size:S
mr-cheffy
requested changes
May 11, 2026
Member
mr-cheffy
left a comment
mr-cheffy
left a comment
There was a problem hiding this comment.
We should do it more like in https://searchfox.org/firefox-main/source/browser/components/urlbar/content/SmartbarInput.mjs#4144-4154
Author
|
This uses the URL that the user selected which is not encoded. But getting |
mr-cheffy
changed the title
decodeURLsOnCopy specdecodeURLsOnCopy spec
Member
|
I meant the code structure instead of having 2 different calls to "copy to clipboard". Also, checking if the url is a data url |
Author
|
I have made the changes as requested. Do tell me if something is still not right. |
ashvwinn
force-pushed
the
decode-urls-on-copy
branch
from
bd6e15f to
d5faeec
Compare
mr-cheffy
requested changes
May 12, 2026
mr-cheffy
requested changes
May 13, 2026
Member
mr-cheffy
left a comment
mr-cheffy
left a comment
There was a problem hiding this comment.
Please fix lint: https://github.com/zen-browser/desktop/actions/runs/25793929248/job/75766372262?pr=13659#step:11:56.
You can run npm run lint:fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decodes URL on copy by shortcut/button if
browser.urlbar.decodeURLsOnCopyis truefixes #13653