Skip to content

no-bug: Make macOS app icon changes available from settings#13479

Open
yordis wants to merge 2 commits into
zen-browser:devfrom
yordis:yordis/app-icon
Open

no-bug: Make macOS app icon changes available from settings#13479
yordis wants to merge 2 commits into
zen-browser:devfrom
yordis:yordis/app-icon

Conversation

@yordis
Copy link
Copy Markdown

@yordis yordis commented Apr 29, 2026 •
edited
Loading

  • Makes the running macOS app icon switchable from about:preferences#zenLooks, so icon variants can be exercised from settings instead of requiring separate branded builds.
  • Shows the selected icon variant directly in settings and packages the alternate asset, so the macOS-specific behavior is visible before it is applied.
  • Keeps this first implementation scoped to macOS because the current runtime icon hook only exists for AppKit, and Windows and Linux remain unchanged for now.
  • Syncs the Zen en-US overlay strings during local import and build, so the new settings UI renders correctly in local development builds.

@yordis yordis requested a review from mr-cheffy as a code owner April 29, 2026 01:13
@dosubot dosubot Bot added size:L This PR changes 100-499 lines, ignoring generated files. Feature labels Apr 29, 2026
@yordis
Copy link
Copy Markdown
Author

yordis commented Apr 29, 2026

Screen.Recording.2026-04-28.at.9.47.27.PM.mov

mr-cheffy
mr-cheffy requested changes Apr 29, 2026
View reviewed changes
Comment thread src/zen/toolkit/common/cocoa/ZenAppIcon.mm Outdated
Comment thread src/zen/common/modules/ZenStartup.mjs Outdated
Comment thread src/zen/images/app-icons/alternate-preview.png
@LemonPotion
Copy link
Copy Markdown

LemonPotion commented Apr 29, 2026

Is there a way to implement this on Windows and Linux? Would be great 🙏

@yordis
Copy link
Copy Markdown
Author

yordis commented Apr 29, 2026

@LemonPotion I never done it for Win and Linux, but I can try to figure it out

@yordis
no-bug: Make macOS app icon changes available from settings
05d9bb0 
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@yordis yordis marked this pull request as draft April 30, 2026 18:07
@yordis
fix(macos): keep Dock icon aligned with app icon setting
77c8cba 
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@yordis yordis requested a review from mr-cheffy April 30, 2026 19:37
@yordis yordis marked this pull request as ready for review April 30, 2026 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mr-cheffy mr-cheffy Awaiting requested review from mr-cheffy mr-cheffy is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

Feature size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yordis @LemonPotion @mr-cheffy