Add variables for int and float types#5
Open
savage13 wants to merge 2 commits intozeldamods:masterfrom
Open
Conversation
leoetlino
requested changes
Oct 15, 2023
Member
leoetlino
left a comment
leoetlino
left a comment
There was a problem hiding this comment.
(sorry for the long delay in reviewing this!)
| self.items = {} | ||
|
|
||
| def _do_read(self, stream: ReadStream) -> None: | ||
| sub_flow_event_indices_offset = stream.read_u64() |
Member
There was a problem hiding this comment.
can we rename these variables to match the names in https://github.com/open-ead/EventFlow/blob/556793186c3065e7b25a51247d0560d7ff401b81/include/evfl/ResFlowchart.h#L71-L83 ?
|
|
||
| if x1a > 0: | ||
| with SeekContext(stream, x8): | ||
| dic = DicReader() |
| self.main_event: Index[evfl.event.Event] = Index() | ||
| self._sub_flow_event_indices: typing.List[int] = [] | ||
| self._sub_flow_event_indices_offset_writer: typing.Optional[PlaceholderWriter] = None | ||
| self.items = {} |
| import os | ||
|
|
||
|
|
||
| class Variable(BinaryObject): |
Member
There was a problem hiding this comment.
VariableDef (to match the actual name in the EventFlow lib)
| kResFlowchartNotFound = 2 | ||
| kEntryPointNotFound = 3 | ||
|
|
||
| class VariableType(enum.IntEnum): |
Member
There was a problem hiding this comment.
This is actually the same enum as ContainerDataType (aka ore::ResMetaData::DataType)
| self.type = stream.read_u16() | ||
| assert self.type == VariableType.kInteger or self.type == VariableType.kFloat | ||
| stream.seek(offset) | ||
| if self.type == VariableType.kInteger: |
Member
There was a problem hiding this comment.
needs handling of int arrays and float arrays
|
Could this be merged please? I am using event-editor daily, and would love for it to be improved! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses Issue #4