Skip to content

Simplified logger implementation #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
zeeshanhaque21 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Simplified logger implementation #2

zeeshanhaque21 wants to merge 1 commit into from

Conversation

@zeeshanhaque21
Copy link
Owner

@zeeshanhaque21 zeeshanhaque21 commented Jul 31, 2024 •
edited
Loading

  • Logger will now conform to io.Writer and return io.Reader
  • Reduced scope of the design in the interest of time

Simplified logger implementation
6947d9d 
- Logger will now conformto io.Writer and return io.Reader
- Reduced scope of the design in the interest of time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sclevine sclevine sclevine approved these changes

@gabrielcorado gabrielcorado Awaiting requested review from gabrielcorado

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zeeshanhaque21 @sclevine